We need to completely free cerebral-router from depending on window.location because it should know nothing about it. All location related api must be provided by addressbar. It will simplify code and testing.

we can use https://github.com/cofounders/urlutils to expose properties like addressbar.origin, addressbar.pathname etc

package.json

• naming
• correct urls
• deps
• authors
• contributors
• license: MIT
• scripts
• keywords
• private: y/n

README

• badges at top, links at bottom
  • npm
  • build status
  • coverage
  • standard
  • commitizen

tests

• folder: tests/
• could be ran on travis
• testing API, not tied to implementation

other files

• LICENSE.md MIT
• CONTRIBUTING.md
• no generated content
• .gitignore
• .npmignore

workflow

• coverage
• standard
• protect master
• commitizen + cz-customizable
• ghooks + validate-commit-msg
• semantic-release
  • version 0.0.0
  • travis
  • cracks

Hello @christianalfoni. It seems you forgot to drop this debug log.

I'm having an issue where the back and forward buttons are working fine unless I've followed one or more links, and then the updates the value in the browsers address bar but the change event doesn't fire.

I haven't dug into the problem yet, I might do tomorrow, but I thought I'd mention just in case you can replicate the behaviour.

Hi,

First of, i am using cerebral router for navigation.
It would be neat, to access the referrer (previous visited url) from the current visited url.
use-case1: i want to return to the previous site after clicking the save-button on a settings page.

1. visit example.com/foo via addressbar
2. enter settings via button click: goTo(example.com/settings)
3. click on save-button at example.com/settings: save settings and redirect to referrer ( example.com/foo )

use-case2: i want to show a message after clicking the save-button on a settings page.

1. visit example.com/settings via addressbar
2. click on save-button at example.com/settings: save settings and show success/error message

While this is possible by saving the current location to state before going to example.com/settings, it would be easier if the new location just knows, where i came from.
Using window.history.back() is not sufficient, because i only want to go back to the previous location in use-case1
Using document.referrer would be sufficient, but it is not possible, because navigation with the router will not change the document.referrer. Is this a desired behaviour?

When an <a> tag with href changes url, the addressbar.on('change') fires twice.

Here's a repo I created to replicate issue: https://github.com/awei01/addressbar-test

Tested on firefox and chrome.

value.replace here become always String.prototype.replace native method. So doReplace is always `true. It must be before above value reassignment.

variant 1

addressbar.replace(newUrl);

variant 2

addressbar.replaceNext();
addressbar.value = newUrl;

variant 3

addressbar.value = '!' + newUrl;

I think is better be consistent and always provide url with origin in event.target.value to represent actual value set to addressbar.