cevoaustralia / cfn-identity-provider Goto Github PK

Testing out integrations, ignore this

Hello,
The lambda code looks pretty dangerous and does not use any logging.

I'm working on refactoring it, I will post an update with better code once it's finished.

Or you should ask for code review.

How to delete the identity provider. i see lambda function can handle the deletion as well. but not sure how to trigger that.

When running the code, I kept getting errors that the metadata could not be parsed. I eventually ran the metadata as one line but unescaped. I was using metadata from Okta specifically.

tr -d '\n' < metadata.xml > out.xml

Hey, awesome repo you have here, but there's one small issue with it:

You have some lines like provider_arn = "arn:aws:iam::" + str(${AWS::AccountId}) + ":saml-provider/" + provider_name which cause an error when you have an account ID beginning with 0. Python barfs on it, so I reckon it would be easier to do provider_arn = "arn:aws:iam::" + "${AWS::AccountId}" + ":saml-provider/" + provider_name

Appears to be an undefined parameter on the update_provider function. References name but the input is arn and doc (assuming the input should be name, doc).

My SAML metadata is > 4,096 bytes, so it cannot be passed as a parameter. I'm trying to save it as a json file on S3 and use a Transform and AWS::Include, but can't get it to work.
AWS' recommendation for large parameter values is "To use a larger parameter value, create multiple parameters and then use Fn::Join to append the multiple values into a single value."
Any other suggestions?