cezarykopacz / ckwavecollectionviewtransition Goto Github PK

:)

In the readme, the following graphics give me "Access denied" errors when I view the readme offline:

• https://bitbucket.org/repo/bdbxyL/images/476354846-object.jpg
• https://bitbucket.org/repo/bdbxyL/images/3022245965-objectCustomClass.jpg
• https://bitbucket.org/repo/bdbxyL/images/3403085542-navigationControllerDelegateObject.jpg

And the following graphics give me "Not Found" errors when I view the readme online:

• https://camo.githubusercontent.com/5ec21bb2c56b67eb32face9cefeeb240ec0c95d0/68747470733a2f2f6269746275636b65742e6f72672f7265706f2f62646278794c2f696d616765732f3437363335343834362d6f626a6563742e6a7067
• https://camo.githubusercontent.com/928dd63dfdaacbda36e429bb31f775cf32edcb07/68747470733a2f2f6269746275636b65742e6f72672f7265706f2f62646278794c2f696d616765732f333032323234353936352d6f626a656374437573746f6d436c6173732e6a7067
• https://camo.githubusercontent.com/928dd63dfdaacbda36e429bb31f775cf32edcb07/68747470733a2f2f6269746275636b65742e6f72672f7265706f2f62646278794c2f696d616765732f333032323234353936352d6f626a656374437573746f6d436c6173732e6a7067

(It is the same three graphics, under "Usage".)

Thanks. (This is a lovely library!)

when set the background color of second-level collection view as an image, issue happens.

In such scenario, click 'back' to reverse to the first level, the background turn to be white color for a while.

IMO, documentation should mention that you need to set self.selectedIndexPath = indexPath; in -collectionView:didSelectItemAtIndexPath: It may save debugging time for others.
You could also make an assertion in code (line ~247) when destinationCollectionViewController.selectedIndexPath is nil with some descriptive comment.

Good job anyway!

The animation only fades when using UICollectionViewCompositionalLayout.

I see a lot of warnings and errors it will be nice to keep it up to date with swift 2.2 compatible

it'd be cool to have a swift 3 version, if you have any interest to create a branch i would like to help with that.

Thank you for this awesome library for collection view.

I have integrated your library in my project, and I have one problem.
After calling UICollectionViewDelegateFlowLayout method - sizeForItemAt, the transitioning cell sizes are doesn't changed.

My code is here and there are written on both of first and second view controller.

extension MyViewController: UICollectionViewDelegateFlowLayout {
    func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize {
        let desiredWidth = (self.view.frame.size.width - 2) / 2
        let desiredHeight = desiredWidth

        return CGSize(width: desiredWidth, height: desiredHeight)
    }
}

Please let me know how can I handle this problem.
Thank you