Giter VIP home page Giter VIP logo

cf-bottom's People

Contributors

aleksandrychev avatar cf-bottom avatar craigcomstock avatar dependabot[bot] avatar kotzaboss avatar lex-2008 avatar lluiscampos avatar mineralsfree avatar mzedel avatar nickanderson avatar nickheythatsme avatar olehermanse avatar vpodzime avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

cf-bottom's Issues

Authentication needed for build queue url

This part needs auth:

    def wait_for_queue(self, url):
        log.debug("Queue URL: {}".format(url))
        queue_item = {}
        while "executable" not in queue_item:
            log.info("Waiting for jenkins build in queue")
            sleep(1)
            r = requests.get(url + "api/json")

config.json and secrets.json

We need to separate out a lot of parameters for @oleorhagen to run the bot. This is a proposal for the file:

config.json:

{
  "bots": [
    {
      "username": "cf-bottom",
      "secrets": "cfengine-secrets.json",
      "trust": ["olehermanse", "vpodzime", "craigcomstock"],
      "reviewers": ["olehermanse", "vpodzime"],
      "jenkins": "https://ci.cfengine.com/",
      "orgs": ["cfengine"],
      "repos": {
        "cf-bottom/self": ["olehermanse", "vpodzime"],
        "cfengine/core": ["olehermanse", "vpodzime", "craigcomstock"],
        "cfengine/enterprise": ["olehermanse", "vpodzime", "craigcomstock"],
        "cfengine/nova": ["olehermanse", "vpodzime", "craigcomstock"]
      }
    },
    {
      "username": "mender-bottom",
      "secrets": "mender-secrets.json",
      "trust": ["oleorhagen", "kacf"],
      "reviewers": ["oleorhagen", "kacf"],
      "jenkins": "https://mender-jenkins.mender.io/",
      "orgs": ["mendersoftware"],
      "repos": {
        "mendersoftware/mender": ["kacf", "oleorhagen", "pasinskim"]
      }
    }
  ]
}

secrets.json:

{
  "GITHUB_TOKEN": "1234abcdef",
  "GITHUB_USER": "cf-bottom",
  "JENKINS_USER": "a111111",
  "JENKINS_TOKEN": "1234abcdef",
  "JENKINS_CRUMB": "1234abcdef"
}

(If JENKINS_CRUMB is missing, it should still work, by not including it in header)

Approve PRs that meet minimum requirements from repository

It would be nice if our various automated tests could function as an approval.

For example, in CFEngine core we run Travis, and we can request Jenkins builds (with options for the difficulty of the jenkins gauntlent like exotics and deployment tests). It would be nice if tom would approve a PR (allowing merge) if both travis and Jenkins were green.

Tom needs to read reviews

Right now, tom doesn't see reviews (in API they are separate from comments) so he will ask for reviews even if PR has been reviewed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.