cgloeckner / pyvtt Goto Github PK

Some operators might not want to support music, for whatever reason. A simple boolean in the settings file could turn this feature off (assuming on by default), and therefore prevent the upload of MP3 files.

This is a parade example for open source software ...

Things that need to be updated in the future:

• How to setup a development environment (like localhost, quick'n'dirty)
• How to setup a proper server (nginx, docker etc.)
• How to setup it for personal use (like hosting it on demand)
• Command line arguments for vtt.py

Since there are a couple of options in the settings.json, this needs to be made clear.

Feel free to add to this list.

Hello,

I am trying to run pyvtt with its default configuration in a throwaway, private LXC guest (so no name, no DNS configuration whatsoever, just a local IP address). From inside the LXC:

root@bullseye-bl35UhyVrM:~# ip -br a sh dev eth0
eth0@if8         UP             192.168.155.120/24 fe80::7c91:7fff:fea4:201b/64 
root@bullseye-bl35UhyVrM:~# getent hosts 192.168.155.120
root@bullseye-bl35UhyVrM:~#

I access the app as http://192.168.155.120:8080 from my local browser. However, when trying to log in, the app gives me ws://localhost:8080 as a websocket URL, which the browser can't connect to.

From my understanding of the code, the URL is generated as something like "localhost by default, unless I can find a better value"; this corner case does not seem to be covered.

It'd be nice if PyVTT could open a new log file at the start of each day. Then operators could elect to clean up historical files on their own schedules using whatever retention strategy they need.

Creating a new file means we don't need to worry about using logrotate or anything similar at the OS level.

Rather than store log events across different log files, I propose you log everything to one file. You can prepend each log line with a severity level (INFO, WARN, ERR, etc). Set a default log level (only log errors, by default) and allow operators to control log level with a command line flag (--loglevel=INFO would log everything of info and above).

This will reduce the number of open file handles, and simplify log cleanup.

Also, consider a --stdout flag that logs everything to standard out, and avoids writing to a log file at all. In Docker environments, this is preferred.

The psutils package may offer a way to get CPU and memory info, if that's something you want to use.

Some people (i.e. me!) don't have a Google account. It'd be great to support multiple social authentication providers. Auth0 does this pretty nicely. Maybe document how to set this up for PyVTT?