Comments (4)
@JorahLee Sorry about the egregious delay, but thanks for the note. Maybe @kakearney can comment on this?
from cdt.
Thanks for the feedback, @JorahLee. You're correct that I got a bit lazy with units, both in my use of the gsw_rho function, and in the documentation of the exact units on the function inputs. Reviewing the Holte et al., 2009 paper, the original Argo-based algorithm referenced in-situ temperature, practical salinity, and potential density.
The easiest fix for the potential density calculation, as noted by @JorahLee, is to use the seawater toolbox sw_pden function. We could do the conversion with the GSW toolbox, but that involves at least 3 conversion steps and introduces lat/lon to the mix... which may be technically more accurate and correct according to TEOS-10 standards, but is probably overkill for this algorithm. I can make that change and add sw_pden to the CDT private folder; @chadagreene, does this sound good to you?
from cdt.
Absolutely, @kakearney, you're the expert here, so do whatever you think is best.
from cdt.
Resolved via 9e12a70
from cdt.
Related Issues (18)
- Landmass avoidance using island HOT 5
- The Z-value in the mann_kendall.m is incorrect when S>=0 HOT 2
- Add variable baseline functionality to anomaly plot function HOT 3
- sinefit returns a constant way off HOT 2
- Add daily_insolation.m functionality to handle Berger 1978 solution
- A Chinese version of CDT Contents HOT 2
- sw_pden calls non-existent functions HOT 6
- Regarding basics - Raw/Processed i/ps??
- extending ekman.m to use wind stress directly rather than calling windstress to compute it HOT 2
- distance2coast.mat do not coast at some locations (around 18 deg E and 15 deg N).
- Incorrect masks generated for specific cases of 2Drange HOT 2
- CDT documenation is not searchable in matlab. HOT 2
- Geomask error for polygons
- implementing SPI
- time step returned by the SPEI
- Example 6 for daily_insolation documentation
- Redundant mean removal in nao index computation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cdt.