chadrem / officer Goto Github PK

Hello there,

I Am trying to use this via PHP.
There are a few things that i wondered.
If, for some reason there would be an faulty command, or bad json, the connection gets closed.
It would be much nicer if the response could be a something with an error in it.
like {"error":"Invalide Command"} or something like that, maybe even with error codes etc...

Also, i did some testing, and trying to unlock a lock that is not set by that connection will also close the connection. In some situations it could be handy to unlock a lock that has been set by someone else, like usage for semaphore.
But still, if it would not be permitted to unlock a lock of someone else, it should not close the connection.

here is the scenario, where officer does not release lock held even after the client is long gone.

1. machine1 - start officer server
2. machine2 - start client which acquires lock and sleeps for say 2000 seconds.

machine 2 was connected to machine 1 using the wireless network in my case.

3. disable wireless on machine2 .

4. kill client on machine2

5. notice that officer stills reports a lock is being held from machine2(waited for > 4minutes)

6. enable wireless network & restart client => now the client hangs waiting to acquire a lock as officer stills report lock is being held from machine2.

hence the state of locks is not updated properly.