chaindev931105 / anchor-coin-flip Goto Github PK

View Code? Open in Web Editor NEW

0.0 1.0 1.0 185 KB

TypeScript 37.00% Rust 63.00%

anchor-coin-flip's Introduction

anchor-coin-flip

anchor-coin-flip's People

Contributors

Watchers

Forkers

btcltc

anchor-coin-flip's Issues

execute wallet

In the 2 txn flow, the core should store the pubkey of the executer , the wallet than can run the 2nd txn.
We don't want it to be the admin since the private key of the executer will need to be in the backend, so we don't want to expose it.

strict enough?

anchor-coin-flip/programs/coin-flip/src/lib.rs

Line 353 in 8f39241

constraint = admin.key() == core_state.admin @ ErrorCode::WrongAdmin,

signer plus admin == core.admin should lock down any option for anyone else to withdraw, right?

usused?

anchor-coin-flip/programs/coin-flip/src/lib.rs

Lines 29 to 31 in 8f39241

 pub fn register(ctx: Context<Register>, args: RegisterArgs) -> Result<()> { 

 Ok(()) 

 }

seems unused, if so let's remove to avoid unneeded noise

purpose?

anchor-coin-flip/programs/coin-flip/src/lib.rs

Line 33 in 8f39241

pub fn deposit(ctx: Context<Deposit>, args: DepositArgs) -> Result<()> {

this is to fill up the house wallet?

Admin/Operator setup

We need to define a new type of user Operator.

Admin:

Creates core.
Defines fee of fee , and in each bet, the fee is split between admin and operator.

Operator:

Defines fee.
Register mint.
Can deposit.
Can withdraw.

Merge?

anchor-coin-flip/programs/coin-flip/src/lib.rs

Lines 253 to 266 in 75d181e

 #[derive(AnchorSerialize, AnchorDeserialize)] 

 pub struct BetSolArgs { 

 pub core_state_nonce: u8, 

 pub amount: u64, 

 pub bet_side: bool, // true = Head, false = Tail 

 } 

 #[derive(AnchorSerialize, AnchorDeserialize)] 

 pub struct BetSplArgs { 

 pub core_state_nonce: u8, 

 pub amount: u64, 

 pub bet_side: bool, // true = Head, false = Tail 

 pub token_mint: Pubkey, 

 }

Can use wrapped sol, then we have only one type of these.

https://github.com/metaplex-foundation/metaplex-program-library/blob/11be56b934b93ebb2066eefabbf7f4f2adbbe04e/auction-house/program/src/lib.rs#L80

https://github.com/metaplex-foundation/metaplex-program-library/blob/11be56b934b93ebb2066eefabbf7f4f2adbbe04e/auction-house/program/src/lib.rs#L95-L127

seperate

anchor-coin-flip/programs/coin-flip/src/lib.rs

Lines 192 to 241 in 8f39241

 let mut hasher = DefaultHasher::new(); 

 [clock, core_state.flip_counter].hash(&mut hasher); 

 let hash = hasher.finish(); 

 if ((hash == 0) ^ args.bet_side) { 

 let vault_auth_seeds = [ 

 VAULT_AUTH_SEED.as_bytes(), 

 core_state.admin.as_ref(), 

 &[core_state.vault_auth_nonce], 

 ]; 

 if !is_native { 

 utils::assert_is_ata(&user_token_account, &user.key(), &token_mint.key())?; 

 anchor_lang::solana_program::program::invoke_signed( 

 &spl_token::instruction::transfer( 

 &token_program.key(), 

 &vault_token_account.key(), 

 &user_token_account.key(), 

 &vault_authority.key(), 

 &[], 

 2 * args.amount - args.fee, 

 )?, 

 &[ 

 vault_token_account.to_account_info(), 

 user_token_account.to_account_info(), 

 token_program.to_account_info(), 

 vault_authority.to_account_info(), 

 ], 

 &[&vault_auth_seeds], 

 )?; 

 } else { 

 utils::assert_keys_equal(user_token_account.key(), user.key())?; 

 utils::assert_keys_equal(vault_token_account.key(), vault_authority.key())?; 

 anchor_lang::solana_program::program::invoke_signed( 

 &anchor_lang::solana_program::system_instruction::transfer( 

 &vault_token_account.key(), 

 &user_token_account.key(), 

 2 * args.amount - args.fee, 

 ), 

 &[ 

 vault_token_account.to_account_info(), 

 user_token_account.to_account_info(), 

 system_program.to_account_info(), 

 user.to_account_info(), 

 ], 

 &[&vault_auth_seeds], 

 )?; 

 } 

 msg!("Congratulations, You won!"); 

 }

need to move this part to a separate method, we want to avoid users being able to see the instruction that says who won.

add more "random" inputs

anchor-coin-flip/programs/coin-flip/src/lib.rs

Line 193 in 8f39241

[clock, core_state.flip_counter].hash(&mut hasher);

should add recent blockhash / slot / etc to the hash seeds , to make it harder to predict.

close core/vault

Incase we update the struct we need to also be able to close the existing accounts or it will not let us create with the updated form.

Also, upon closer, all funds in core/vault should be sent to the admin.

allowed amounts

anchor-coin-flip/programs/coin-flip/src/lib.rs

Line 180 in 8f39241

args.amount,

core account should have a vector of allowed bet amounts , need to validate the amount is one of those given.
we don't want someone to make a huge bet and clean the house on luck (or exploit)

fee need to be stored on core

anchor-coin-flip/programs/coin-flip/src/lib.rs

Line 212 in 8f39241

2 * args.amount - args.fee,

can't let the user determine the fee, they can put it as 0.

withdraw destination should be in core and mint too

anchor-coin-flip/programs/coin-flip/src/lib.rs

Lines 443 to 448 in 8f39241

 pub struct CoreState { 

 pub core_state_nonce: u8, 

 pub vault_auth_nonce: u8, 

 pub admin: Pubkey, // admin public key 

 pub flip_counter: u64, 

 }

we want to make each core use a specific mint, to avoid a mess of people trying to bet with various unrelated mints.

the withdraw destination should be predefined doing creation, to ensure more security
=> can add an update instruction to all of these for flexibility

Newer Anchor

anchor-coin-flip/programs/coin-flip/Cargo.toml

Line 19 in 75d181e

anchor-lang = "0.19.0"

Is it possible to move to latest Anchor?
I saw they published some great features like better errors.

	pub fn register(ctx: Context<Register>, args: RegisterArgs) -> Result<()> {
	Ok(())
	}

	#[derive(AnchorSerialize, AnchorDeserialize)]
	pub struct BetSolArgs {
	pub core_state_nonce: u8,
	pub amount: u64,
	pub bet_side: bool, // true = Head, false = Tail
	}

	#[derive(AnchorSerialize, AnchorDeserialize)]
	pub struct BetSplArgs {
	pub core_state_nonce: u8,
	pub amount: u64,
	pub bet_side: bool, // true = Head, false = Tail
	pub token_mint: Pubkey,
	}

	let mut hasher = DefaultHasher::new();
	[clock, core_state.flip_counter].hash(&mut hasher);
	let hash = hasher.finish();

	if ((hash == 0) ^ args.bet_side) {
	let vault_auth_seeds = [
	VAULT_AUTH_SEED.as_bytes(),
	core_state.admin.as_ref(),
	&[core_state.vault_auth_nonce],
	];

	if !is_native {
	utils::assert_is_ata(&user_token_account, &user.key(), &token_mint.key())?;
	anchor_lang::solana_program::program::invoke_signed(
	&spl_token::instruction::transfer(
	&token_program.key(),
	&vault_token_account.key(),
	&user_token_account.key(),
	&vault_authority.key(),
	&[],
	2 * args.amount - args.fee,
	)?,
	&[
	vault_token_account.to_account_info(),
	user_token_account.to_account_info(),
	token_program.to_account_info(),
	vault_authority.to_account_info(),
	],
	&[&vault_auth_seeds],
	)?;
	} else {
	utils::assert_keys_equal(user_token_account.key(), user.key())?;
	utils::assert_keys_equal(vault_token_account.key(), vault_authority.key())?;
	anchor_lang::solana_program::program::invoke_signed(
	&anchor_lang::solana_program::system_instruction::transfer(
	&vault_token_account.key(),
	&user_token_account.key(),
	2 * args.amount - args.fee,
	),
	&[
	vault_token_account.to_account_info(),
	user_token_account.to_account_info(),
	system_program.to_account_info(),
	user.to_account_info(),
	],
	&[&vault_auth_seeds],
	)?;
	}
	msg!("Congratulations, You won!");
	}

	pub struct CoreState {
	pub core_state_nonce: u8,
	pub vault_auth_nonce: u8,
	pub admin: Pubkey, // admin public key
	pub flip_counter: u64,
	}

chaindev931105 / anchor-coin-flip Goto Github PK

anchor-coin-flip's Introduction

anchor-coin-flip

anchor-coin-flip's People

Contributors

Watchers

Forkers

anchor-coin-flip's Issues

Recommend Projects

Recommend Topics

Recommend Org