challenger-deep-theme / vim Goto Github PK

View Code? Open in Web Editor NEW

585.0 585.0 42.0 52 KB

FlatColor vim colorscheme

License: MIT License

Lua 5.61% Vim Script 94.39%

color-scheme vim

vim's People

Contributors

Stargazers

Watchers

vim's Issues

lightline colorscheme is missing

Good day, migrated from FlatColor to challenger-deep and can not enable the lightline theme.

The error states: lightline.vim: Could not load colorscheme challenger_deep..

I directly copied the line from github, so it should be correct. Just to be sure, I set it with 'colorscheme': 'challenger_deep'

On an unrelated note, are there plans to change the address of the plugin? Currently vim-plug lists it simply as vim, which is definitely worse than the previous FlatColor.

Signify highlights are incorrect

Problem

I'm not sure why Signify highlights are incorrectly set to LineNr here, but GitGutter highlights are correctly set to their respective colors.

Proposed Solution

Signify highlights can either be linked to DiffAdd, DiffDelete, and DiffChanged (as original defined in Signify plugin here) or they can be set in this colorscheme to their respective colors, just as GitGutter signs are set, via:

call s:h("SignifySignAdd", {"fg": s:green, "bg": s:bg_subtle})
call s:h("SignifySignDelete", {"fg": s:red, "bg": s:bg_subtle})
call s:h("SignifySignChange", {"fg": s:yellow, "bg": s:bg_subtle})
call s:h("SignifyLineDeleteFirstLine", {"fg": s:red, "bg": s:bg_subtle})

Let me know which solution you prefer to implement and I can send in a PR.

What is the name of the font used in the image in README?

This is not a bug report. I just wanted to know which font you used in the image in readme file.

Better MatchParent highlight

I consider current MatchParent highlight as inefficient. I easily get lost when there are several brackets around. I suggest to use #c991e1 aka purple for foreground color + bold text.

My tested data:

python
```
"john {0} doe ()"
```

htmldjango

{% load static %}

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <title></title>
</head>
<body>

</body>
</html>

Notes:

in the Python string it looks like LA Lakers color combo
MatchParent is also used by matchtagalways plugin
in the htmldjango syntax it does not block green curly parents

Include (this) kitty theme

If you want to provide a theme for the kitty terminal as well as the .Xresources version:

# challenger deep
foreground   #cbe3e7
background   #1e1c31
selection_background  #fbfcfc

# black
color0       #565575
color8       #100e23

# red
color1       #ff8080
color9       #ff5458

# green
color2       #95ffa4
color10      #62d196

# yellow
color3       #ffe9aa
color11      #ffb378

# blue
color4       #91ddff
color12      #65b2ff

# magenta
color5       #c991e1
color13      #906cff

# cyan
color6       #aaffe4
color14      #63f2f1

# white
color7       #cbe3e7
color15      #a6b3cc

Love the theme. Maybe a wiki page to collect these would be helpful.

s/tremcolors/termcolors on line 23

I thought this was too tiny for a pull req, so just reporting here :)

Yellow in light scheme seems rather unreadable.

The bright yellow color in light version seems rather unreadable to me, should be darker / oranger.

BTW, this is really good for Christmas! Thank you so much! Enjoy your holiday :)

Consider contributing the theme to base16

base16 is a collection of themes and since you already have vim, emacs and terminal setup, it might be nice if you could add your theme there.

Lighter line number foreground color

IMO is current LineNr foreground color quite unreadable. I prefer higher contrast. I suggest same color as for normal text (#cbe3e7 aka clouds). What do you think about it?

P. S. Thanks for you colorscheme, I love it so much (I had tried several colorschemes before).

Cursor colour clashes with search highlight

When using hlsearch, the search highlight has the same colour as the cursor, and therefore any motion inside the pattern will not be seen.

Consider a `vis` theme, please

Good day,

It would be nice if your theme was available for the vis editor.

macOS + alacritty + tmux + vim = color issue

I just ran into some coloring issue that I wanted to share, and perhaps contribute some troubleshooting tips in the docs.

Problem

When using vim in alacritty & tmux on macOS, colors were completely off in vim:

I was not able to replicate the issue using iTerm2 + tmux + vim.

Here are the relevant settings I had for alacritty, tmux, and vim:

Alacritty

Per the official repo:

# ...

# challenger deep
colors:
  # Default colors
  primary:
    background: '0x1b182c'
    foreground: '0xcbe3e7'

  # Normal colors
  normal:
    black:   '0x100e23'
    red:     '0xff8080'
    green:   '0x95ffa4'
    yellow:  '0xffe9aa'
    blue:    '0x91ddff'
    magenta: '0xc991e1'
    cyan:    '0xaaffe4'
    white:   '0xcbe3e7'

  # Bright colors
  bright:
    black:   '0x565575'
    red:     '0xff5458'
    green:   '0x62d196'
    yellow:  '0xffb378'
    blue:    '0x65b2ff'
    magenta: '0x906cff'
    cyan:    '0x63f2f1'
    white:   '0xa6b3cc'

Tmux

# ... 

set-option -g default-terminal "xterm-256color"

# ...

Note: I'm not using the official tmux theme. See my dotfiles for the full config.

vim

Per the official repo:

" ...
Plug 'https://github.com/challenger-deep-theme/vim', { 'as': 'ChallengerDeep' }
" ...

if has('nvim') || has('termguicolors')
  set termguicolors
endif

colorscheme challenger_deep

" ...

Solution

Research led me to this reddit thread.

What solved it for me was setting the following tmux config option:

# ...

set-option -g default-terminal "xterm-256color"
+ set-option -ga terminal-overrides ',xterm-256color:Tc'

# ...

Here is what vim looks like in alacritty + tmux on macOS now:

syntax highlighting differs from emacs ?

Do you know why I get different syntax highlighting colors between vim & emacs? Emacs is more close to your screenshots. In vim, it miscolors keywords (function,null) to be blue and other things like paramters aren't highlighted compared to Emacs.

I'm using vim-polyglot. What do you recommend?

Left vim, right emacs

challenger-deep-theme / vim Goto Github PK

vim's People

Contributors

Stargazers

Watchers

Forkers

vim's Issues

Problem

Proposed Solution

Problem

Alacritty

Tmux

vim

Solution

Recommend Projects

Recommend Topics

Recommend Org