chamini2 / hapi-auth-ip-whitelist Goto Github PK

The ip library that you are using doesn't match IPv4 ranges written in CIDR notation, this results in "Internal Server Error" when using hapi-auth-ip-whitelist.

The ip source code:

var ipv4Regex = /^(\d{1,3}\.){3,3}\d{1,3}$/;

ip.isV4Format = function(ip) {
  return ipv4Regex.test(ip);
};

Clearly the regex will never match a CIDR IP range.

https://github.com/indutny/node-ip/blob/43e442366bf5a93493c8c4c36736f87d675b0c3d/lib/ip.js#L87

Test environment I don't want to verify any IP address, how to do it?

Hi!
Is there any progress on supporting hapi v16 and v17? It contains breaking changes which makes the plugin incompatible so it would be nice to perform the upgrade as well.
If you haven't started this yet I feel I can provide a PR by the end of this week ✌️

I have tested the library with an API deployed in AWS but it always is saying that receives requests from "127.0.0.1" localhost. Is there a way to make it recognize the real IP for the request

I have used this code in the past to extract real IP from requests:

const ip = request.headers['x-forwarded-for'] ? request.headers['x-forwarded-for'].split(',')[0] : request.headers['x-real-ip'] || request.info.remoteAddress