chaodyz / ngx-line-truncation Goto Github PK

Is it possible to upgrade the dependencies to support Angular 15?

Library makes use of MutationObserver which is not available during Server Side Rendering of the angular app link. It would be nice if the library had a simpler fallback method if the MutationObserver doesn't exist.

[line-truncation] work's only once. Not accept furhter values updates. So when i change my value from 2 to 100 it continues to show only 2 rows.

https://github.com/DiZhou92/ngx-line-truncation/blob/6423a7b9ac9e70b87160427ce35905cc0a845937/projects/line-truncation-lib/src/lib/line-truncation.directive.ts#L135

Hi there, thanks for the cool library. However, I find that sometimes the element style is still hidden after rendering.

It happens randomly and I don't have a small test case for you but I though it is worth raising it here in case you can see anything obvious.

Could it be possible that clientHeight is <=0 ?

                if (contentHeight > targetHeight) {
                    truncate(element, this.lines, this.options.ellipsis, this.handler.bind(this));
                }
                else {
                    this.renderer.removeStyle(this.element, 'visibility');
                }

When I change line-truncation dynamically, it will not call truncate with callback this.handler, and thus no emit event.

Is it possible to get the upgrade the dependencies to angular v13?

Hi
I have an issue with emojis truncation
Here is screenshot of this issue

and link to the repository, where you can see my code
https://github.com/tqwqt/angular-line-truncation-test

Hi,

Could you please fix the peer dependencies? You are currently 'forcing' [email protected] dependency for anyone who uses your lib. You get a message such as:

npm WARN [email protected] requires a peer of @angular/common@~8.0.1 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/core@~8.0.1 but none is installed. You must install peer dependencies yourself.

You should configure peerDependencies to contain entire version 8 or I wouldn't be as worried as specifying future proof versions (e.g. > 8).

In case of using input watchChanges and too long text on each update hasTruncated - will produce two values.

• First value emited after acutal value change.
• The second will be emitted after line-truncation finish work and provide truncated value to DOM.
  So hasTruncated will emit isTruncated = false however actually text has been truncated.

Environment: See example

• Editor that allow to write a long notes.
• Note preview should display a few first lines.
• Allow view all note's text by clicking on show more/ show less.

Step to reproduce:

• Change text into textarea (Text should have enought symbols to apply truncation)
• Press Save / sync changes button

Expected behavior:

• hasTruncated - should emit one value true

Actual Behaviour:

• hasTruncated - emitted true
• hasTruncated - emitted false

Rich texts are getting stripped out when it's in the last element to be truncated, however, any element before would still persist rich text

https://stackblitz.com/edit/angular-jnavtd

Thanks for the lib! Works fine in my Angular 8, but would be good to up the peer deps.

Just a question - not sure if its intended or not, but line truncating does not work properly when used in combination with fxFlex and changing resolution dynamically. Works ok for hard reload with F5 which is why this is not gonna be an issue in most situation, but still - elements can resize dynamically in some circumstances.

Can the line truncation ellipses end with a word word. As now the ellipses end in middle of a word. It would be better to have an option for ending the line truncation with a whole word.

Hello and thank you for this cool library!

I've faced an issue when setting the disabled directive to true, and after that, resizing a window. Here are the screenshots:

The problem is, that in the putbackElement, when disabled, this.elementClone is null, so, we've got an exception.

Any ideas on how to fix it?

Thanks a lot!

I have an array of text and variable 'text', that takes a value from array each animation cycle,
but text truncates only first time.
I have screenshout where you can see that hasTruncated event stopped fires.
Also I created repo with code that can reproduce my issue: https://github.com/tqwqt/angular-line-truncation-test

Hey,

as title suggest, can you update peer deps for Angular 9? :)

Hi all,

this project does not work with Angular 11 or higher due to the following error:

Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"~11.2.6" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^10.0.1" from [email protected]
npm ERR! node_modules/ngx-line-truncation
npm ERR!   ngx-line-truncation@"^1.6.9" from the root project

I think the dependencies/peer dependencies must be updated or be more vague, e.g. @angular/common: "^10.0.0 || ^11.0.0". This is probably similar to #22 .

Thank you!

My goal is add "see more" button, after pressing it text must expands.
But I cant set lineCount to 999+, because of #10

Can we add input property disabled which will disable truncation logic?

<p [line-truncation]="lineCount" [disabled]="!isExpanded"></p>

I have tested ngx-line-truncation and realize that it works on first init. but when i scroll out of a virtual repeat range, and scroll then back, the text is not cutted any more.

ngx-line-truncation is not supporting angular 15 version.