Giter VIP home page Giter VIP logo

vraymtl_glsl's People

Contributors

chazbg avatar dian-nikolov-chaos avatar dtoshevcg avatar vkoylazov avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

vraymtl_glsl's Issues

is it right to scale microNormalLocal twice in getGGXDir?

in function 'vec3 getGGXDir()' in vratmtl_glsl microNormalLocal was scaled before get reflect dir. Then you pass this scaled microNormalLocal to 'getGGXContribution()', and in this function the microNormalLocal was scaled again to calculate BRDF.

is it right to scale this vector twice?

Unsupported features

Are threre plans to support or partially support these unsupported features in the future ?

Unsupported features:
Glossy Fresnel (supported only in sheen) because the calculations are a bit heavy for real-time rendering.
SSS and fog parameters
Normal/Bump Mapping - this is outside of the scope of the current implementation because the normal is usually computed separately before any BRDF calculations
Shadows, AO and other global illumination effects - outside of the scope of the current implementation
Displacement

I wonder if the function computeDirectDiffuseContribution should be divided by π at the end

vec3 vrayMtlDiffuse(vec3 lightDir, vec3 normal) {
return vec3(max(0.0, dot(lightDir, normal)));
}
vec3 computeDirectDiffuseContribution(VRayMtlInitParams params, VRayMtlContext ctx, vec3 lightDir) {
vec3 res = vec3(0.0);
if (params.roughness < 1e-6) {
res = vrayMtlDiffuse(lightDir, ctx.geomNormal);
} else {
res = vrayMtlDiffuseRoughness(lightDir, ctx);
}

if (ctx.hasSheen) {
	vec3 sheenLightDim = getSheenAlbedoLightDim(params.sheenColor, dot(lightDir, ctx.geomNormal), ctx.sheenGloss);
	res *= sheenLightDim;
}

return res;

}
i cannot find a π division at this function, according to formula, should res to divided by π at the end?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.