Accept non-PR "plain" commit for commenting on about github-review HOT 6 OPEN

I have a prototype on a branch, can you test it to see how it works for you? If it works fine I will refactor it, add more tests and merge it. @andrelkin #43 you would use the same entrypoint as for reviewing a PR but it would only submit inline comments and no approval status.

from github-review.

If you get a chance to do it, feel free to send a pull request, I would be happy to review it.

from github-review.

@charignon, thank you! You beat me to the patch that I've been also slowly developing (already testing). Sure I'll review and test your work.

As to

you would use the same entrypoint as for reviewing a PR but it would only submit >inline comments and no approval status.
you must mean there are 2 PR:s for this issue and I should pick #43 to place my comments in. Sorry I could not get the last sentence though.

Have a wonderful week ahead :-)!

from github-review.

I meant that:
(1) you should call github-review-start to start reviewing a commit
(2) you should call either github-review-approve or github-review-comment or github-review-reject to submit a review on a commit, even if they will just comment (there is no concept of rejecting or approving a commit)
(3) when reviewing a commit, github-review will only look at inline comments and not top level comments (comments above the start of the diff), as there are no API to submit the latter.

Does that make sense?

from github-review.

Thank you for spelling out! Indeed I learned that already while working on my patch version, but how could you know :-). I really appreciate your care!

from github-review.

Does that make sense?

I think it does, I don't see any other option.

from github-review.