Comments (2)
Thanks for the suggestion, it would be a great feature to add and I definitely miss not having that in github-review
It would be a lot easier after the mode support indeed! If you are interested in prototyping it, I would love to take a look at what you come up with.
Right now, the package just manipulates text and is very simple which makes it compatible with a broad range of use cases. Adding support for multi line comment would be awesome and I am thinking of how to maintain the accessibility of the package while doing that (and I don't have experience with that). If you use a screen reader to access this package, feel free to reach out to me to discuss, I would want to understand if that would be a problem for you. You can DM me at https://twitter.com/lc2817.
Also if you have an opinion on this feature, feel free to comment / upvote!
from github-review.
Thinking on this for a bit more time, I've realized there could be a simple method of making multi-line comments manageable, which is to add a check at the beginning of any inline comment to see if it represents a range of lines from the start of the comments, something like:
#+3
# This is a comment spanning the next 3 lines
# after the last comment line.
Lines
more lines
even more lines
I might try this out myself (My Elisp-fu is pretty bad) but if you have a better suggestion, let me know.
from github-review.
Related Issues (20)
- Edit comments i gfm-mode HOT 2
- Code review is inconsistent if new codes gets pushed while reviewing
- Filter ^M characters in diffs
- Using graphql instead of api v3 for reducing number of network calls
- Document the token scope HOT 1
- Got an error from the GitHub API (wrong-type-argument listp error)! when i try to pull request using forge
- Add syntax highligh for review HOT 1
- docs need clarification (or code needs changing?) HOT 4
- Can only see topmost comment HOT 1
- Should start at the beginning of the buffer HOT 2
- Outline mode doesn't work with github-review-mode HOT 1
- Got an error from the GitHub API (wrong-type-argument stringp nil)! HOT 19
- improve diffs with delta
- Applying github-review-approve with no comments fails
- What's the Auth section of the README about? HOT 6
- Feature request - Magit Delta support HOT 1
- graphql seems to require _api.github.com/graphql_ in authinfo
- Readme info about doom-emacs appears to be outdated
- conflicts with `(setq diff-default-read-only t)` HOT 1
- Elisp errors are reported as coming from the GH API, and debug-on-error doesn't work HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-review.