charlieetienne / material-vcl Goto Github PK

I love the Material Theme (dark) in HeidiSQL 10.1 - except when I highlight a line, there is no background color behind/over the highlighted characters. When highlighted, it does however turn all the text white, so you can kind of tell it's highlighted, but it's very hard to tell. I want the highlighted text to remain the same color, but some kind of highlight/overlay color to easily show what is highlighted. Is there some way I can solve this?

In Heidi, you can scarcely tell what is highlighted:

In NPP by contrast, you can easily tell what is highlighted:

I have been in Heidi->Tools->Preferences->SQL and tried many things, but nothing works.

What can be done?

When you select text with this theme, the background doesn't change at all, and text color doesn't seem to change at all either, though non-standard text color changes of course and on normal text you can just barely make out a difference. As noted in HeidiSQL/HeidiSQL#471.

As shown in HeidiSQL/HeidiSQL#485:

Popped-up windows have no differentiation from it's background in many instances.

As @ansgarbecker pointed out, shadows may be impossible as there's a ticket about it marked wontfix: https://quality.embarcadero.com/browse/RSP-11751.

However a simple border could accomplish this as well.

Discovered in HeidiSQL's implementation, but the maintainer said it was an upstream issue to open here. When you close the program left click on the upper right corner where the cross closes the window behind HeidiSQL.

Here's a link to the original github issue: HeidiSQL/HeidiSQL#1217

Originally reported this in HeidiSQL (HeidiSQL/HeidiSQL#956) but he said to report it here instead, and added an "upstream" label there, so I'm assuming it's more to do with the theme itself rather than anything he's doing in Heidi specifically. I'm copy/pasting my original issue here, hopefully this is enough for you to go on.

Steps to reproduce this issue

1. In a single blank Query tab, write multiple SELECT queries (e.g., "select top 100 * from table1; select top 100 * from table2; select top 100 * from table3, ...")
2. Execute them.

Current behavior

It makes individual tabs for each query below the SQL editor textbox, e.g., [table1 (1r x 21c)] [table2 (2r x 9c)] [table3 (10r x 49c)]
but there is no visual way to distinguish which tab is active. The tabs above the editor box have a light blue strip at the bottom to show which tab is active, but the result tabs below the editor do not.

Expected behavior

The result tabs below the SQL editor textbox should get the same "active" styling as the tabs above it; that is, a light blue strip at the bottom of the tab.

Environment

• HeidiSQL version:
  11.0.0.5919 (though the issue was also present going back to 10.0)
• Database system and version:
  SQL Server 2017
• Operating system:
  Windows 10 x64