cheeaun / phanpy Goto Github PK

Hi,
I just noticed the settings popup is not showing correctly. It starts appearing, then switches to being all black.
If I'm very fast I managed to change the theme, but without changing the settings window behaviour.
Tried on Opera and Chrome on Android 13.
PD: the design is lovely!

When I clicked on image, video.
I expect pressing ESC will close the image or video popup.
Anyways I enjoy your UI!

I have 6 shortcuts in the form of multi-column and because Phanpy tries to fit them all on the screen, each column becomes very narrow.

It'd be great if you could allow users to set column width. I like having everything laid out instead of having to click through these buttons and use "shift+scroll" to scroll between columns.

Thanks a lot for this great app!

Clicking Home makes UI scroll to the top. But in mobile view it often makes an unwanted text select of the label

Hi, love the app! Would be amazing if there was a swipe feature implemented to view the next photo in a post with multiple photos.

Describe the bug
I logged in my GoToSocial server with Phanpy. When I click the compose button at the right botton corner, the browser popped out the alert message "Failed to load instance configuration. Please try again.". After clicking "OK", the browser reload the web app. Therefore, I cannot create new post.

To Reproduce
Steps to reproduce the behavior:

1. Login an account on a GoToSocial server.
2. Click the compose button at the right-bottom corner.
3. An alert with the message "Failed to load instance configuration. Please try again." popped out.
4. After clicking "OK", the browser reload the web app.

Expected behavior
Display the compose dialog to create a new post.

Investigation
The alert comes from the following code in src/components/compose.jsx:

  const currentAccount = getCurrentAccount();
  const currentAccountInfo = currentAccount.info;

  const configuration = useMemo(() => {
    try {
      const instances = store.local.getJSON('instances');
      const currentInstance = currentAccount.instanceURL.toLowerCase();
      const config = instances[currentInstance].configuration;
      console.log(config);
      return config;
    } catch (e) {
      console.error(e);
      alert('Failed to load instance configuration. Please try again.');
      // Temporary fix for corrupted data
      store.local.del('instances');
      location.reload();
      return {};
    }
  }, []);

According to the function initMasto(params) in src/app.jsx, since GoToSocial uses v1 Mastodon api, the uri "https://mydomain.com", rather than the domain "mydomain.com", is used as the index of a member of instances. So, the index of the member in instances at line 6 above contains the protocol part.

I found that in the function onSubmit in src/pages/login.jsx, the the protocol part is always removed from instanceURL. This value then becomes the value of currentAccount.instanceURL. So, the value of currentInstance at line 7 above doesn't contain the protocal part.

Hence, at line 8 above, the configuration cannot be retrieved, and then an error is catched.

Solution
I tried to change a line in initMasto(params) function in app.jsx from

      instances[(domain || uri).toLowerCase()] = info;

to

      instances[(domain || uri.replace(/(^\w+:|^)\/\//, '')).toLowerCase()] = info;

to make sure no protocol part is including the index of the member of instances. It works with my GoToSocial server.

However, I am not sure whether the whole uri was used intentionally for other purposes. So, I simply create an issue, instead of a PR.

Desktop (please complete the following information):

• OS: Arch Linux 6.1.8-arch1-1
• Browser: Firefox
• Version: 109.0 (64 bit)

Smartphone (please complete the following information):

• Device: iPhone 13 Pro
• OS: iOS16.3
• Browser: Safari
• Version: 16.3

GoToSocial Version
GoToSocial 0.6.0 git-f9e5ec9

Phanpy version
Phanpy git-305bb92

Photo in feed starts scrolling after preview is opened. And it can't be focused on mobile (to start scrolling) in any way (only click that opens preview)

Example: https://youtube.com/shorts/cC1nkFHr9I8?feature=share

Videos are opened muted with no media controls

Instead of closing photo preview – (web) app is closing fully

Having lists' timelines availabe is great, I'd love to have CRUD operations for lists and their members as well.

Status column scroll is noticeably laggier than scrolling feed (tested on mobile, Firefox and Google Chrome browsers)

Not sure if it is visible on the video example: https://youtu.be/_trWui7Kb1I

UPD.: another example https://youtube.com/shorts/tqtidp7RF7Q (laggy scroll, then normal scroll)

UPD2.: it's post like/boost buttons cause scroll lags. When they are on screen – there are a lot of freezes when scrolling

I personally don't need content warnings so in the official (not really official I guess) client I check the option to automatically expand all content warnings. It would be great to have this option in phanpy.

Scroll is lagging when unopened spoiler in the FOW

I get that this is mostly opinionated, but I do think it's probably best for media to be displayed in 16:9 as that's what the most common ratio is

• hashtags are not sorted by popularity
• no weekly usage numbers

Especially useful if it's linking to a Mastodon instance different from the logged-in user's.

User can set several "known languages" and then UI stop showing translate button for those messages. Also when translating message – transcription comes first which is not what i was looking for. I guess transcription should be hidden or at least less visible. It can take all screen space in case of big messages.

Describe the bug

• Which site: dev.phanpy.social

Expected behavior
I don't want to see translate functionality for languages i know. After pressing "translate" button, I want to see translation, not transcription

Screenshots

View

Transcription goes first and takes a lot of space. And I don't want translate for Russian language at all, as I'm a native speaker

Additional context
Here is related discussion in Elk UI

Could be very useful if you want to keep a post open while still being able to scroll your feed

Quickly made this in inspect element (slightly broken because I did just copy and paste the element)

Describe the bug
As in the title. Happens with both dev.phanpy.social and phanpy.social.

To Reproduce
Steps to reproduce the behavior:

1. Go to "Shortcuts Settings"
2. Choose "multi-column"
3. Add a "Trending" column of any instance
4. See that the "Trending" column doesn't appear

Expected behavior
The Trending column will show up

Screenshots

Desktop (please complete the following information):

• OS: Windows
• Browser Edge
• Version 112.0.1722.34 (Official build) (64-bit)

Additional context
'Trending' works fine in "Floating button" or "tab/menu bar" layout.

Btw, thanks so much for making Phanpy. Phanpy makes Mastodon usable for me and I'm using Mastodon much more frequently because of that.

All of the actions you can take on a post you are viewing appear to be in a context menu. On mobile, there is no mouse so you must long press to show the context menu. However, the browser uses the same action to show its context menu. This results in the browser context menu blocking the app context menu. You need to close that every time you want to interact with a toot.

Would be nice if there was an icon you could click to open the context menu instead. Or configurable options to expose icons for context menu items that you use frequently so you can do the actions in one click.

Thanks for the great client!

Would it be possible adding a handful of rows to the post textarea? I have noticed it is rather too small now (only two rows).

I believe it's the norm in the Fediverse to (usually) have your message as public and reply should be private most of the time.

As it says on the tin. Mastodon's main web client allows me to send a toot by pressing Ctrl+Enter while in the compose textbox, so why not Phanpy?

(This project is great so far btw, keep up the good work! :D)

Message not appearing in feed after submission, also there is no "New posts" button at the top of the feed

To see your own message i need to manually refresh the page

Describe the bug
When navigating to my own posts through Settings > Account > Posts, the account modal gets dismissed but the settings modal remains on screen

To Reproduce
Steps to reproduce the behavior:

1. Tap the Settings gear in the top left corner
2. Tap own account name
3. Tap on "Posts"

Expected behavior
Both the account modal, as well as the settings modal get automatically dismissed so I can view my posts

Desktop (please complete the following information):

• OS: macOS
• Browser: Safari
• Version: 16.3

Will it be possible to align the thread line to the bubble? This is how it shows now:

Proposing something like this:

I hope the video would be easier to understand than text: https://youtu.be/dwVnCEe2gVg

In the video I'm using this thread: https://phanpy.social/#/pkm.social/s/110169741586783061
And this is the comment I want to view comfortably (without having to click into it): https://phanpy.social/#/pkm.social/s/110182364639376007

In short I want the text panel that takes up the right half of the screen to stay intact when you open an image (less transitioning is better). The image will take up the left half of the screen. There's just so much space around an image in the current layout while the text is squished to the right. If users want to view the full original image they still have the option to view original media:

A few minor points to improve:

• When having the image takes up the left half of the screen, resize the image to make it fit the entire viewing panel (I'm assuming that when the viewer click into an image they want to see it clearly and you may not agree with this)
• I'm thinking of people post high-resolution images and maybe that's why you want the image panel to take up that much space? So maybe having the width of the image pane adjustable by dragging it?

If any of the above is hard to implement, just doing this #99 is already a good improvement.

Thanks so much!

Otherwise this is a bit odd:

1. Click a Mastodon link
2. Right panel that shows that post and thread appears
3. Click on a post author
4. Bottom panel that shows user appears
5. Hit <esc>
6. Right panel disappears, but user bottom panel still remains open

This state in (4):

I write messages in 2 languages. It's hard to select them, because languages list is too big.

It would be great if known languages (languages with disabled translate functionality) will at the top of selector for easier access

Describe the bug
Toots matching some filters are not filtered out of the timeline.

• Which site: phanpy.social

To Reproduce
Steps to reproduce the behavior:

1. Go to your instance's preferences screen
2. Click on 'Filters' in the menu
3. Add a new filter
4. Go to Phanpy's timeline
5. See toots that should have been filtered out.

Expected behavior
Toots matching one or more of the filters should be hidden from the timeline.

Desktop (please complete the following information):

• OS: Ubuntu 22.10
• Browser Firefox
• Version 111.0.1 (64-bit)

Smartphone (please complete the following information):

• Device: Pixel 6Pro
• OS: Android 13
• Browser Firefox
• Version 111.1.1

Describe the bug
The scroll position inside a boosts carousel resets on click

• Which site: both dev.phanpy.social and phanpy.social

To Reproduce
Steps to reproduce the behavior:

1. In Phanpy, navigate to a boosts carousel
2. Scroll right inside the carousel
3. Click on one of the posts in the carousel
4. The carousel's scroll position resets to its initial left position. The post I clicked on doesn't open.

Expected behavior
The scroll position persists and the selected post is opened

Desktop (please complete the following information):

• OS: macOS 13.3
• Browser: Safari 16.4

Additional context
This bug has been around for at least a few versions of Phanpy. It only happens in Safari on macOS. Neither Chrome on macOS nor Safari on iOS exhibit this behaviour.

Describe the bug
Can't post with GoToSocial

• Which site: phanpy.social

To Reproduce
Steps to reproduce the behavior:

1. Login with a GoToSocial Account
2. Write a post and click post
3. See error (CORS Missing allow header)

Expected behavior
a post to be sent

Response header data

HTTP/2 204 No Content
access-control-allow-headers: Origin,Content-Length,Content-Type,Authorization,Upgrade,Sec-Websocket-Extensions,Sec-Websocket-Key,Sec-Websocket-Protocol,Sec-Websocket-Version,Connection
access-control-allow-methods: POST,PUT,DELETE,GET,PATCH,OPTIONS
access-control-allow-origin: *
access-control-max-age: 120
content-security-policy: frame-ancestors 'self'
date: Fri, 31 Mar 2023 12:04:34 GMT
permission-policy: interest-cohort=()
strict-transport-security: max-age=31536000; includeSubDomains
x-content-type-options: nosniff
x-frame-options: SAMEORIGIN
x-request-id: yggrwdw704001hhvymg0
x-xss-protection: 1; mode=block
X-Firefox-Spdy: h2

Desktop (please complete the following information):

• OS: linux
• Browser: firefox
• Version: 111.0.1

Additional context
Posting works with Pinafore.

The GoToSocial server has the following traefik (reverse proxy) configuration.

traefik.docker.network=traefik

traefik.http.middlewares.mash-gpa-gotosocial-add-response-headers.headers.customresponseheaders.X-XSS-Protection=1; mode=block
traefik.http.middlewares.mash-gpa-gotosocial-add-response-headers.headers.customresponseheaders.X-Frame-Options=SAMEORIGIN
traefik.http.middlewares.mash-gpa-gotosocial-add-response-headers.headers.customresponseheaders.X-Content-Type-Options=nosniff
traefik.http.middlewares.mash-gpa-gotosocial-add-response-headers.headers.customresponseheaders.Content-Security-Policy=frame-ancestors 'self'
traefik.http.middlewares.mash-gpa-gotosocial-add-response-headers.headers.customresponseheaders.Permission-Policy=interest-cohort=()
traefik.http.middlewares.mash-gpa-gotosocial-add-response-headers.headers.customresponseheaders.Strict-Transport-Security=max-age=31536000; includeSubDomains

traefik.enable=true
traefik.http.routers.mash-gpa-gotosocial.rule=Host("gay-pirate-assassins.de")
traefik.http.routers.mash-gpa-gotosocial.middlewares=mash-gpa-gotosocial-add-response-headers
traefik.http.routers.mash-gpa-gotosocial.service=mash-gpa-gotosocial
traefik.http.routers.mash-gpa-gotosocial.entrypoints=web-secure
traefik.http.routers.mash-gpa-gotosocial.tls=true
traefik.http.routers.mash-gpa-gotosocial.tls.certResolver=default
traefik.http.services.mash-gpa-gotosocial.loadbalancer.server.port=8080

Describe the bug

Using phanpy.social, when I visit this (long) thread I use to dump images, I get automatically teleported to the first post of the thread. This, weirdly, only seems to happen with that thread in particular (although I haven't found a comparably long thread to test it out).

To Reproduce
Steps to reproduce the behavior:

1. Go to https://phanpy.social/#/mastodon.social/s/110210993720490742
2. The last post of the thread will load (this might change if I add more posts
3. Wait a few seconds.
4. The page will load the whole thread and scroll back to previous posts.

Expected behavior

The page should not scroll back.

Screenshots

Desktop (please complete the following information):

• OS: elementary OS 6.1 Jólnir uilt on Ubuntu 20.04.6 LTS
• Browser: Tested on Firefox and Chrome
• Version: Firefox 112 and Chrome 112.0.5615.121 (same version!)

Own profile shows this section :)

Clicking "Follow" will show an error

Up and down arrow already scrolls the page, would be great if they move and highlights the current toot and selects it (like clicking on it)

Describe the bug
Some of my posts show a lower fav count in Phanpy than on the Mastodon web interface. Though the individual "favourited your status" notifications do all appear in Phanpy as expected.

To Reproduce
Steps to reproduce the behavior:

1. Post something
2. Wait for people to favourite it
3. In Phanpy, open the post either from the timeline or from your own profile

Desktop (please complete the following information):

• OS: macOS
• Browser: Safari
• Version 16.3

1. Click to start composing
2. Type "x" or drag an image file in
3. Click ESC and the dialog with "You have unsaved changes. Are you sure you want to discard this post?" appears and disappears quickly

On dev:

The dialog in this screenshot flashes (appears and quickly disappears) if we use ESC instead of clicking the X button. This screenshot was taken by clicking the X button:

On dev, not sure about prod.

This is more troublesome when the selected toot is a boost, in a carousell like this:

Rationale:

I find that I always do this:

1. See a toot that's a reply
2. Wonder what is the context
3. Select it
4. Right pane opens up
5. Press k to select it
6. Press k again, to see the replied to toot

Current:

Suggested:

Maybe have to make provisions if the original toot is too tall?

Describe the bug
When I click the link, it shows pop up: MastoHttpNotFoundError: Record not found

To Reproduce
Steps to reproduce the behavior:

1. Go to https://phanpy.social/#/s/109713159990382360
2. Click on link (https://utcc.utoronto.ca/~cks/space/blog/web/AggressiveStealthyWebSpide)
3. See error

Expected behavior
phanpy direct to link

Screenshots

Desktop (please complete the following information):

• OS: macOS Ventura 13.1
• Browser Firefox
• Version 109.0

Additional context
Looks like it occurs randomly. For some links it directs, for some it shows popup error.

Using Firefox 108.0.1 on Arch Linux, the website's favicon shows up in the bookmark with a white background.

Describe the bug
A clear and concise description of what the bug is.

• Which site: both

To Reproduce
Steps to reproduce the behavior:

1. Open a post with a PNG file with transparency
2. The areas that should be transparent are grey

Expected behavior
Transparency handling in the thumbnail should be the same as in full size after you click on the thumbnail.

Screenshots
Attached screenshots from Phanpy dev version and the default Mastodon web client.

Desktop (please complete the following information):

• OS: Linux
• Browsers: Firefox 111 and Web (Epiphany) 44.

Smartphone (please complete the following information):

• Device: Moto G7
• OS: Android
• Browser: Firefox
• Version 111

Both dev and prod.

Reproducible in https://dev.phanpy.social but not https://phanpy.social

1. Navigate with j/k on timeline to a post that is threaded (or not threaded)
2. Hit <enter> to open thread
3. Immediately press j/k

Expected

4. Focus is on the posts in the thead/side panel

Observed

4. Focus is on the timeline, it might switch to be on the posts in the thead/side panel after it finishes loading

Compose doesn’t do anything under mobile Safari.

I hope the video would be easier to understand than text: https://youtu.be/pBQTAS11IEw

In word:

Currently if you're viewing an image like this

Pressing Esc would escape the thread and go straight to the Home view.

I propose pressing Esc would first go back to the thread view first:

and pressing Esc again would go back to the Home view.

Describe the bug

Selecting users from context menu doesn't work.

• Which site: dev.phanpy.social

To Reproduce
Steps to reproduce the behavior:

1. Go to dev.phanpy.social
2. Start writing a new post
3. Type any mastodon user handle
4. Context menu appears with users matching
5. Can't select a user from the list neither by clicking nor pressing enter.
6. Can't navigate through the list of suggested users using the up and down arrows

Expected behavior
Clicking or pressing enter on the selected user should complete their handle and close the context menu.

Desktop (please complete the following information):

• OS: Linux
• Browser: Firefox
• Version: 111

Smartphone (please complete the following information):

• Device: Motorola Moto g7
• OS: LineageOS 20
• Browser: Chrome
• Version: 111