Allow closures with any amount of arguments about percy HOT 10 CLOSED

Thanks! I hope that it's enought

from percy.

Yes! It 's working !

from percy.

Can i take it ?

from percy.

Absolutely!

Are the above details enough?

If not I'd be more than happy to go into more detail or answer any questions that you might have!

from percy.

The docs is still update ? I have the last version of the repo but tests fails when i run ./test.sh

from percy.

Tests are currently failing for a couple of cases due to some recent changes - I'll get that fixed

In the meantime you can use cargo test -p html-macro-test to verify that the html macro still works as expected.

Let me know if you have any issues there!

from percy.

i added a test like this, and strangely it hasn't failed

fn closure_with_no_parmas() {
    HtmlMacroTest {
        desc: "No parameter defined for the closure",
        generated: html! {
            <div onclick=||{}></div>
        },
        expected: html! {<div></div>},
    }
    .test();
}

I'm missing something ?

from percy.

Ah sorry I misled you!!!

In non wasm32 targets the html macro completely ignores closures.

So we need to test this using our in browser tests

If you branch off of the latest master you'll see that I moved your test to closures.rs here -> 404dd70

Very sorry for that! Let me know if there are any other stumbling blocks

from percy.

I want to run closure' s tests but this command does'nt work wasm-pack test crates/virtual-dom-rs --chrome --headless -- --test closures

from percy.

Ahhh I'm using functionality that hasn't been released by wasm-pack yet.

Could you try

cargo install -f --git https://github.com/rustwasm/wasm-pack ?

Then you should be able to run the tests

from percy.