chriscoastal / backgammon2.0 Goto Github PK

Found an issue when hitting a blot. Took a single move (4) and both moves (4,2) were removed from remainingMoves array.
Exepected to still have the second (2) move remaining.

To reproduce:
dice: 2,4 (no moves taken)
blot was hit with the 4 and entered singleMoves and combosMoves block in gameState.ts.

Currently, the diceCombinations are calculated on drag, but should be moved to be calculated when the roll is made (only if an activePlayer is assigned). diceCombinations should then be used for validating available points and be updated after a checker is moved in state via useReducer.

setMoveTaken is being dispatched twice for at least some move cases. Check updateRemainingMoves. May be related to issue #12.

useDrop accept field in BoardPoint.tsx is not updating when the activePlayer toggles (should switch the result from the ternary argument). Other related movement logic seems to be working correctly.

After refactoring getValidPoint, the point highlight now remains for some time after a checker is dropped. The UI was previously very responsive to the drop action.

The accept property in the reactdnd useDrop function has a bug in BoardPoint.tsx.
This && operator is currently checking for the CHECKER1 property on the ItemTypes object (true), then setting useDrop to only accept CHECKER2 regardless of the activePlayer.
The bug could be fixed by changing the && to a ternary.

Checker movement that combines multiple dice must take each dice individually (each single dice move must be valid and not land on a closed (occupied) point. Currently, even if the initial move is invalid, subsequent moves can still be taken.

Potential fix requires redoing the move combination logic.

Currently players are only able to move opponents checkers (checkers move in the current player's direction); however, logic for determining whether a point is open or closed is correct.