chrismuir / baidugeo Goto Github PK

For function get_coords(), if any of the API calls fail with a connection error AND type is set to data.frame, then this step will throw an error:

# If input arg "type" is data.frame, parse the vector of json strings, 
# extract data into a data frame.
if (type == "data.frame") {
  out <- from_json_coords_vector(location, out)
}

since con error: 500 is not a valid JSON string.

when i use your instruction , i find these errors when download the packages using R
Error (main.R#8): Failed to install 'baidugeo' from GitHub:
C symbol name "rs_canBuildCpp" not in load table
Here are my codes:
install.packages('devtools')
library(devtools)
install_github("ChrisMuir/baidugeo", force=TRUE)
library(baidugeo)

I wonder why they happened.THX

Hello,

I recently try to use your package for Geocoding. Here is response from running the bmap_get_coords(locs).

Per this API document, the coordinates API call can take an optional argument for City/Prefecture. I should include a city arg to function baidugeo::bmap_get_coords(), so that users have the option of passing in a city string with the main address string.

Only tricky thing will be that the location arg of function bmap_get_coords() is vectorized, so I'm not sure if it's best to require that a character vector passed to the new arg city have the same length as the character vector passed to arg location. We could also allow for a scalar string input to arg city, and recycle it so that it's applied to each address in arg location.