chrispritchard / fsh Goto Github PK

This command does not work properly: (let s = "1x5)BC")

Not sure what should be done about this: maybe count " in the bracket push algorithm?

can this be available as a global dotnet tool ?

https://docs.microsoft.com/en-us/dotnet/core/tools/global-tools

On Windows, it's common to use "cd " or "cd" to switch to the current drive's root. In FSH, only "cd /" works.

To reproduce:

1. Type echo 0123456789ABCDEF into the shell
2. Resize the window to be a very small width
3. Try to recall the previous line by pressing the up arrow, crashing the program

System.ArgumentOutOfRangeException
  HResult=0x80131502
  Message=The value must be greater than or equal to zero and less than the console's buffer size in that dimension.
Parameter name: left
Actual value was 30.
  Source=System.Console
  StackTrace:
   at System.ConsolePal.SetCursorPosition(Int32 left, Int32 top) in E:\A\_work\297\s\corefx\src\System.Console\src\System\ConsolePal.Windows.cs:line 794
   at System.Console.SetCursorPosition(Int32 left, Int32 top) in E:\A\_work\297\s\corefx\src\System.Console\src\System\Console.cs:line 329
   at System.Console.set_CursorLeft(Int32 value) in E:\A\_work\297\s\corefx\src\System.Console\src\System\Console.cs:line 265
   at [email protected](Int32 priorIndex, String soFar, Int32 pos) in C:\Users\Akeeton\dev\FSH\src\LineReader.fs:line 86
   at LineReader.readLine(FSharpList`1 prior) in C:\Users\Akeeton\dev\FSH\src\LineReader.fs:line 172
   at [email protected](FSharpList`1 prior) in C:\Users\Akeeton\dev\FSH\src\Program.fs:line 164
   at Program.main(String[] _arg1) in C:\Users\Akeeton\dev\FSH\src\Program.fs:line 171

If you run (List.init 10 id) it will create a list ten ints long. This will be printed to out.
If you then run (let s = "1x5\)BC") the same list from before will be printed; it wasn't cleared.

(test) |> test should throw numerous errors. (test) alone does, but the piping swallows the error.

So it shows something other than my beautiful face when linked.

Console writing is not aligned properly on osx. Each char typed jumps to a new line. Test and resolve.

Additionally, there are precompiled releases available. These were pre-built using dotnet publish for win-x64, linux-x64 and osx-x64, and should run without needing the framework installed. Access these from the releases link.

But there is no release links

A .rc file, a run command file, is a file that is loaded and run on startup. FSH could support these for loading precommands: e.g., you could define 'grep' as (fun args -> ...) then this would be compiled and interpreted as possibly a built-in on load

E.g. (let test = "") + SHIFT+ENTER will place the cursor on the same line, position zero. It still functions correctly (next typed character appears on the following line, cursor moved), but looks odd.

(let test = [SHIFT+ENTER] works correctly, as does typing non-code (e.g. echo [SHIFT+ENTER])

The new code which extends the surface area with long lines introduces a horizontal scroll bar on windows. When multi-line, the clearing functionality causes the scroll bar to scroll to the right, which feels odd.

This would help solve issues #10 and #15 I believe.

Instead of a string array and caps on length based on line position, find something a little more abstract - perhaps typed lines and history can be stored and processed in a way agnostic of the UI? This would allow better flexibility based on the state of the terminal.

For example, cmd on windows when resized does a word wrap on written text - this isn't possible in the current state of fsh. It might result in unreadable F# (typed in) but is better than the issue from #15 where we just crash. Alternatively, powershell doesn't wrap but also permits horizontal scrolling. Text is never 'capped'. This would also solve #15, and maybe #10 too, and would be better for code.

For example, running git clone https://github.com/chrispritchard/fsh will render nothing to the screen. However git pull from a git dir will output as normal (up to 'date with master', etc). Note, even though the former instruction renders no output, it still works fine.

My theory is that external processes that manipulate the outstream, e.g. by rendering a progress bar, are not being connected properly by the process launcher function.

Append would be useful in some scripting scenarios

Performance of printing is atrocious on unix systems. Suspect this due to known problems using cursor top.

This might make it easier to use FSH, if users don't need to have .net core installed and build expertise in order to get going. On the other hand, the project is a bit educational re F#/dotnet core... so... but better to be egalitarian anyway.

Right now, FSH has a simple title on startup. Support adding a version number? Possibly from a git command or extract?

It appears that shift is not registered as a modifier when enter is pressed, as it is on windows. Why can't everyone just use Windows? It would be soooo much simpler ;p

maybe some intellisense display could be given via

https://github.com/fsharp/FsAutoComplete

not an expert, but that would be super cool ofc!

just have no idea of in moder shells this is done (intellisense/autocomplete)

Thank you so much for this amazing project!

Hello, I gave this project a test run on Windows.
It would be great if cd ~ worked as well.

I'm guessing it would require a small change in https://github.com/ChrisPritchard/FSH/blob/master/src/Builtins.fs#L46 right?
Replace any ~ with Environment.GetFolderPath(Environment.SpecialFolder.UserProfile)

Would you accept a PR?