christian-putzke / freshrss-pocket-button Goto Github PK

It seems that the extension is not working with the latest snapshot of FreshRSS.

I think the commit 2038d50 had changed the logic of Minz_Request forward. You can't pass a url string anymore. I'm getting the following error while trying to connect to Pocket:

PHP Fatal error:  Uncaught TypeError: Minz_Url::checkControllerUrl(): Argument #1 ($url) must be of type array, string given, called in /app/www/lib/Minz/Request.php on line 386 and defined in /app/www/lib/Minz/Url.php:117
Stack trace:
 #0 /app/www/lib/Minz/Request.php(386): Minz_Url::checkControllerUrl()
 #1 /config/www/freshrss/extensions/freshrss-pocket-button/Controllers/pocketButtonController.php(74): Minz_Request::forward()
 #2 /app/www/lib/Minz/Dispatcher.php(121): FreshExtension_pocketButton_Controller->requestAccessAction()
 #3 /app/www/lib/Minz/Dispatcher.php(50): Minz_Dispatcher->launchAction()
 #4 /app/www/lib/Minz/FrontController.php(60): Minz_Dispatcher->run()
 #5 /app/www/p/i/index.php(57): Minz_FrontController->run()
 #6 {main}
  thrown in /app/www/lib/Minz/Url.php on line 117" while reading response header from upstream

It looks like enabling the extension makes items "shorter" than they should be.

Default (no extension):

With extension:

my FreshRSS instance is self-hosted and does run on a non-standard port.
When I click the "connect" button in the Pocket Button config to authorize with pocket, the redirect_uri parameter generated for the https://getpocket.com/auth/authorize request doesn't include that port.

I believe this leads to the autorization failing. To be more precise, it looks like the authorization does happen on Pocket's side, but FreshRSS / the extension is missing the response and never recognizes that it is authorized.

if I tweak the pocket.com Authorization URL to contain the port the redirection does seem to work but the connection isn't established. In my pocket.com settings the third-party app I created is listed as authorized, but clicking the pocket icon in FreshRSS yields an error "Adding article to Pocket failed! Pocket API error code: 107"

The pocket button in FreshRSS is only an outline by the way, even after my hacked attempt at fixing the redirect_uri.

Any ideas?