christianfds / manga_downloader Goto Github PK

Add some unit tests for coverage of keys utils and functionalities for the manga downloader.

Add a Dockerfile to allow the code to run without the need to have python or to need to install its dependencies.

The README.md should also be updated to included commands to build and the volume needed to export the files.

At the moment most (if not all) methods are lacking docstring, it would be easier to understand the code if there was.

A nice way to do so is by using the njpwerner.autodocstring extension on VSCode. It generates templates to be filled for the methods wanted.

If the specified output folder doesn't exists, an error is raised. It should create the folder if needed.

Download this manga? Y/N  Y
1 - Chapter #1
Which indexes to download?

on hitting enter without typing anything the program crashes with following error:

Traceback (most recent call last):
  File "manga_downloader/manga_downloader.py", line 118, in <module>
    manga_downloader(args)
  File "manga_downloader/manga_downloader.py", line 85, in manga_downloader
    selected_chapters, chapters = select_chapters(provider, manga)
  File "manga_downloader/manga_downloader.py", line 61, in select_chapters
    selected_chapters = parse_chapter_selection(response)
  File "manga_downloader/manga_downloader.py", line 29, in parse_chapter_selection
    chapters = chapters + [int(section_range[0])]
ValueError: invalid literal for int() with base 10: ''

@christianfds IMO It would be nice to validate manga links using http link regexes and having a test that allows us to see the parsing being successful and/or failing and handling said failures.

As current iteration we iterate one by one on all the search result when searching the title.
eg: on my case, it's Pain full to go trough the whole screen to find Youjo Senki with the keyword Youjo Senki when it actualy take 7 times pressing 'N' to get what i wan't with other different keyword

I think it will be convenient to the user to actually have a list of the search result and selecting what they want to download instead of going trough all of that. is this idea still on viable with what you want with this project to be?