christophherr / prometheus Goto Github PK

The theme fails with errors.

The problem is that in setup.php on lines 22, 40, & 48, the path uses '' instead of '/'. When I changed the source it loaded fine.

The problem exists in load-assets.php line 55 as well.

Looking forward to working with the theme.

GaryJones 8 hours ago Contributor
With PHP 5.6 specified in composer.json as the minimum, the short array syntax could be used throughout.

GaryJones 8 hours ago Contributor
Move this array to a config/plugins/simple-social-icon.php file?

Haven't made up my mind about it.
From a separation standpoint, yes.
From an "is it really necessary standpoint..." undecided...
From a usability standpoint, maybe no...

All,
I'm looking for an example of a customized page template. Could you provide me an example or some additional instruction to setup a just page template with Prometheus 2? I've copied the page_landing template and have tried to add the genesis_after_header hook but can't get it to echo correctly. Code is below.

<?php
/**
 * Prometheus 2.
 *
 * This file adds the landing page template to the Prometheus 2 Theme.
 *
 * Template Name: Full Post Image
 *
 * @package ChristophHerr\Prometheus2
 * @since   1.0.0
 * @author  Christoph Herr
 * @license GPL-2.0+
 * @link    https://www.christophherr.com/
 */

namespace ChristophHerr\Prometheus2;

// Adds landing page body class.
add_filter( 'body_class', function( $classes ) {
	$classes[] = 'full-post-img-page';
	return $classes;
});

// Removes Skip Links.
//remove_action( 'genesis_before_header', 'genesis_skip_links', 5 );

add_action( 'genesis_setup', function() {

	add_action( 'genesis_after_header', 'stride_after_header');
	function stride_after_header() {
		echo '<p><strong>A piece of extra content after the header and nav</strong></p>';
	}

});



// Dequeues Skip Links Script.
add_action( 'wp_enqueue_scripts', function() {
	wp_dequeue_script( 'skip-links' );
});

// Forces full width content layout.
add_filter( 'genesis_site_layout', '__genesis_return_full_width_content' );

//echo 'hello';


// Removes site header elements.
//remove_action( 'genesis_header', 'genesis_header_markup_open', 5 );
//remove_action( 'genesis_header', 'genesis_do_header' );
//remove_action( 'genesis_header', 'genesis_header_markup_close', 15 );



// Removes navigation.
//remove_theme_support( 'genesis-menus' );

// Removes breadcrumbs.
//remove_action( 'genesis_before_loop', 'genesis_do_breadcrumbs' );

// Removes footer widgets.
//remove_action( 'genesis_before_footer', 'genesis_footer_widget_areas' );

// Removes site footer elements.
//remove_action( 'genesis_footer', 'genesis_footer_markup_open', 5 );
//remove_action( 'genesis_footer', 'genesis_do_footer' );
//remove_action( 'genesis_footer', 'genesis_footer_markup_close', 15 );

// Runs the Genesis loop.
genesis();

https://github.com/christophherr/prometheus/blob/develop/lib/functions/autoload.php#L22
https://github.com/christophherr/prometheus/blob/develop/lib/functions/autoload.php#L36

GaryJones 8 hours ago Contributor
If the intention is for someone to amend the config files, you should also allow for them to potentially remove the config file altogether. Add checks here that the file is readable, before assuming it is, to avoid a fatal error.

Experienced programmer but brand new to wordpress. This project (plus the mustardseed sass partials) makes sense to me. Sass is the way I handle css in other projects. Yet wordpress/genesis has this entirely different user-centric never-see-the-code approach. In my case I have just one site, I'm not creating and developing and bunch of themes. I'm struggling to decide which approach to adopt. Certainly I would/could make the wordpress portion of my site more visually compatible with my main site if I can share some sass.

But this repo and mustardseed are a few versions behind the parent theme (now at 2.9.1)

What's the procedure for updating (or is there one)? We have to take the current parent + sample theme, find the changes, and port them into partials ? So that work is ongoing: keeping up with genesis? Sorry to ask such a newb question. Appreciate any guidance very much. Thank you.