chromium / vim-codesearch Goto Github PK

Some folks are reporting that getcurpos() call in Vim is causing an error due to the function not being available. It may be possible to replace that with getpos('.').

Not sure if this is my config somehow, but here's the problem I'm having...

I open up a .cc under src (content/browser/loader/navigation_url_loader_network_service.cc for example)
:pwd is c:\src\cr\src
:CrSearch foo
works fine, opens a buffer with the results, but now :pwd is c:\src\cr
Ctrl-O back to the .cc, then :CrSearch foobar

"Codesearch: foobar" 1534 lines --0%--
Error detected while processing function crcs#CodeSearch:
line 2:
Traceback (most recent call last):
File "", line 1, in
File "c:\src\Dropbox\utils\vim-codesearch/vimsupport.py", line 60, in inner_call_wrapper
vim.command('echoerr "{}"'.format(str(e.message).replace('"', '\"')))
vim.error: Vim(echoerr):Vim(file):E325: ATTENTION

As long as I ":cd src" before I run :CrSearch foobar, things work.

cd \src\cr\src
vim base\task_scheduler\scheduler_worker_pool_impl.cc
/Start (to get to SchedulerWorkerPoolImpl::Start)
:CrCallgraph (works fine, 7 refs)
Ctrl-O (back to Start)
move down a few lines to AutoSchedulerLock
:CrCallgraph
Found a swap file by the name "c:/tmp//c%%src%cr%src%Callgraph.swp"
dated: Wed Jun 07 15:20:27 2017
file name: c:/src/cr/src/Callgraph
modified: YES
user name: scott host name: RIVER-VAN
process ID: 1039952
While opening file "Callgraph"

(1) Another program may be editing the same file. If this is the case,
be careful not to end up with two different instances of the same
file when making changes. Quit, or continue with caution.
(2) An edit session for this file crashed.
If this is the case, use ":recover" or "vim -r Callgraph"
to recover the changes (see ":help recovery").
If you did this already, delete the swap file "c:/tmp//c%%src%cr%src%Callgraph.swp"
to avoid this message.

"Callgraph" 24 lines --4%--
Error detected while processing function crcs#Callgraph:
line 2:
Traceback (most recent call last):
File "", line 1, in
File "c:\src\Dropbox\utils\vim-codesearch/vimsupport.py", line 50, in inner_call_wrapper
return func(*args, **kwargs)
File "c:\src\Dropbox\utils\vim-codesearch/vimsupport.py", line 314, in RunCallgraphSearch
buffer_num = _SetupVimBuffer('call', 'Callgraph')
File "c:\src\Dropbox\utils\vim-codesearch/vimsupport.py", line 113, in _SetupVimBuffer
name=name, source_root=_GetCodeSearch().GetSourceRoot(), type=t))
vim.error: Vim(file):E325: ATTENTION
Press ENTER or type command to continue

Pressing ENTER takes me to the old results for Start, not those for AutoSchedulerLock.

This is basically issue #4 but in a different file.

This works

1. Open extensions/browser/extension_request_limiting_throttle.cc.
2. Go to line 38 and move cursor above throttling_entry_.
3. :CrXrefSearch

This fails

1. Above line 38 add a single comment.
2. Go down one line and move cursor above throttling_entry_.
3. :CrXrefSearch

vim-codesearch is at revision 179860a.

Let it be possible to pull in the plugin via something like:

so `=path_to_chrome . 'tools/vim/vim-codesearch.vim'`

Repro:

1. Open src/extensions/renderer/extension_helper.cc
2. Go to line 60, over the ExtensionHostMsg_UpdateDraggableRegions symbol
3. Execute :CrXrefSearch

Expected behavior: Finds xrefs

Actual behavior: Can't determine signature for .../src/extensions/renderer/extension_helper.cc:ExtensionHostMsg_UpdateDraggableRegions

Vundle reports the following error: Error running:

:helptags ~/.vim/bundle/vim-codesearch/doc

E154: Duplicate tag "quickfix" in file /blah/blah/.vim/bundle/vim-codesearch/doc/crcs.txt

REPRO STEPS:

1. Update all plugins with :VundleUpdate
2. CrSearch file:BUILD.gn webauth_browsertest.cc

EXPECTED RESULT:
Finds some results, just like https://cs.chromium.org/search/?q=file:BUILD.gn+webauth_browsertest.cc&sq=package:chromium&type=cs&ssfr=1 finds content/test/BUILD.gn

ACTUAL RESULT:
No results for query file:BUILD.gn\ webauth_browsertest.cc

Maybe the problem is that the space character gets escaped with a backslash? Not sure if this escaping is intentional (the user can always handle the escaping themselves, depending on the query the user wants?).