chubbyphp / chubbyphp-swoole-request-handler Goto Github PK

I'm sorry, the bug in my project must me somewhere else

I ran into the following error when trying to emit a response with a cookie that had no samesite attribute set.
Fatal error: Uncaught TypeError: Swoole\Http\Response::cookie(): Argument #8 ($samesite) must be of type string, null given in /vendor/chubbyphp/chubbyphp-swoole-request-handler/src/SwooleResponseEmitter.php:41

This is with PHP 8.0 and Swoole 4.6.0.
It's pretty easy to work around this bug by ensuring all cookies have a Lax samesite but it's not ideal.
I believe the proper fix is to send the empty string instead of null. So make this change to the SwooleResponseEmitter class

    private function mapSameSite(SetCookie $cookie): ?string
    {
        if (null === $sameSite = $cookie->getSameSite()) {
            return '';
        }

        return str_replace('SameSite=', '', $sameSite->asString());
    }

Then cookies are sent without error and they do not have samesite attribute at all.