Comments (5)
Thanks for the detailed options, I agree on your thoughts and think option 1
is the best way to go.
from jacoco-badge-generator.
@larskristianhaga just released v2.11.0 also available via major tag v2 with new input for setting the heading of workflow summary. The new input is workflow-summary-heading
. 🚀
from jacoco-badge-generator.
Works like a charm, thanks for the quick feedback and implementation!
from jacoco-badge-generator.
I'm assuming you mean to specify a custom heading? That should be easy enough to do. And would definitely make it easy to read for a case like yours since otherwise there isn't a way to distinguish which output is for which module.
from jacoco-badge-generator.
@larskristianhaga I can think of at least three alternatives for this. Any thoughts on which one you think might be better?
- The first option I can think of is to add an action input to allow overriding the current heading of "JaCoCo Test Coverage Summary", and leaving the rest of the formatting as it currently is.
- The second option I can think of is to actually leave the heading alone, and to use the existing overrides of the left side of the badges in the bullets. E.g., if the left side of the badge was overridden from "coverage" to "coverage (module 1)", then in the workflow job summary to change that bullet to: "coverage (module 1): [percentage]".
- The third option I can think of is to combine both of the above. Add an input to override the heading of the workflow job summary, and also change the bullets to use the left-side badge overrides.
My intuition is that 1 above is probably the way to go. Option 2 won't cover the case where someone didn't override the left side of badges in a multi-module case (e.g., maybe they have the badges in a table in the readme identifying the modules in some other way). And Option 3 seems like it would be redundant (e.g., if the heading is overridden to identify the module, then the current "Coverage" and "Branches" is clear).
What are your thoughts?
from jacoco-badge-generator.
Related Issues (20)
- Feature Req: Support glob to find jacoco csv files in multi module projects HOT 4
- Jacoco report not generated when using Java 17 HOT 2
- No Jacoco report with Java 17 HOT 2
- Feature Req: Badge for multi-module Maven project HOT 3
- Option to suppress logging output to workflow job summary
- Update Python to 3.12 in CI/CD workflows when running unit tests
- Matrix testing Python versions for unit tests and CLI mode
- Feature Req: How to use directly without github action? HOT 2
- BUG: An extra __pycache__ file with root permission will break the workflow HOT 3
- Feature request: absolute path for jacoco-csv-file HOT 5
- Sample badges not showing in GitHub Marketplace listing
- Refactor main block to extract a main function
- Add alternate entry point for running as command-line utility outside of GitHub Actions
- Workflow to publish package to PyPi during release for CLI usage
- Question: Badges was not generated HOT 3
- Feature Req: Generate badges from JaCoCo reports in xml format HOT 7
- Replace the use of GitHub Action's deprecated set-output HOT 7
- Output a GitHub Actions workflow job summary
- Replacement for set-output may break some self-hosted cases
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jacoco-badge-generator.