Giter VIP home page Giter VIP logo

Comments (7)

cicirello avatar cicirello commented on May 28, 2024 1

I thought of an additional option, essentially a variation of the first one: Create a new input without csv/xml in its name, and deprecate the existing jacoco-csv-file input, but keep it around for now. It avoids the potential downside of just adding jacoco-xml-file (e.g., might cause confusion leading to false assumption that both reports are needed, as well as the possibility that jacoco might later introduce yet another format). But at the same time it temporarily avoids a breaking change.

from jacoco-badge-generator.

cicirello avatar cicirello commented on May 28, 2024

@japarson I'm not familiar with Pester so I took a look at it. Based on their docs it looks like only the xml report is generated. It looks like they adopted jacoco's xml format but not jacoco itself.

Anyway, I think xml report support is a reasonable request. It shouldn't be difficult to parse. I don't think an input to turn on option is likely necessary, and can probably just go by file extension. I know jacoco uses the standard xml extension when it generates an xml report. Can you confirm whether Pester's report uses xml file extension as well?

from jacoco-badge-generator.

japarson avatar japarson commented on May 28, 2024

@japarson I'm not familiar with Pester so I took a look at it. Based on their docs it looks like only the xml report is generated. It looks like they adopted jacoco's xml format but not jacoco itself.

Anyway, I think xml report support is a reasonable request. It shouldn't be difficult to parse. I don't think an input to turn on option is likely necessary, and can probably just go by file extension. I know jacoco uses the standard xml extension when it generates an xml report. Can you confirm whether Pester's report uses xml file extension as well?

Pester reports use the xml file extension by default:
image

Thank you so much for considering this request. I mentioned the new input option to turn it on because I saw there was an input specifically for csv files: jacoco-csv-file. Would I still use this input for an xml file?

from jacoco-badge-generator.

cicirello avatar cicirello commented on May 28, 2024

@japarson when I replied earlier I had forgotten that the input has csv in its name. So a new input definitely makes more sense.

from jacoco-badge-generator.

japarson avatar japarson commented on May 28, 2024

@japarson when I replied earlier I had forgotten that the input has csv in its name. So a new input definitely makes more sense.

I should have included my reasoning in the original post. My bad there.

Thinking it through some more, I think there are actually 2 options here:

  1. Change the name of the existing input to jacoco-file and add some documentation about the possible input types.
    • This is a "major" level breaking change (in the context of semantic versioning).
  2. Add a new input specifically for xml files jacoco-xml-file.
    • This is a "minor" level change.

I'm not sure what the best option is. What do you think?

from jacoco-badge-generator.

manoj-paypay avatar manoj-paypay commented on May 28, 2024

Hi @cicirello Thanks :). I wanted to know if this support is added or not? I am trying to use the command line utility but it doesn't work for xml with and without file type format jacoco-xml-file and jacoco-file.

from jacoco-badge-generator.

cicirello avatar cicirello commented on May 28, 2024

Hi @manoj-paypay no, it doesn't support JaCoCo XML reports yet, only the CSV reports at the present time.

from jacoco-badge-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.