cifkao / confugue Goto Github PK

The @configurable decorator should check whether the callable has already been decorated (e.g. because it is a subclass of a decorated class) and if yes, make sure that the new settings are consistent with the old ones. In particular, maybe the new params should be added to the existing list instead of overriding it (unless the subclass overrides __init__...?).

The from_yaml and from_yaml_file class methods could be added to the @configurable-decorated callable (as a shortcut for creating a Configuration object). It should be possible for a decorated class to override them or to opt out.

Support cfg['a.b.c'] as syntactic sugar for cfg['a']['b']['c'], and similarly cfg.get('a.b.c').

Also consider supporting list indices, e.g. cfg['a[0].b'] for cfg['a'][0]['b'].

Consider what to do about keys that contain dots and/or square brackets. I don't know if I like the idea of forbidding them altogether. Currently there is no restriction on what keys can be (they don't even need to be strings) and I'm not sure having this feature is worth breaking that.

Add @configurable.method(key), which will be configured from self._cfg[key] by default (i.e. when called directly). It should also be configurable normally, i.e. via Configuration.configure(obj.method) (this should already work whether or not the method is decorated with @configurable).

The 'class' key is not being marked as used when deleted from config_dict in _configure_impl().