cirzen / choco-jetbrainsmono Goto Github PK

Hi. Followup from https://chocolatey.org/packages/jetbrainsmono#comment-5067829733

I see that this is your first Chocolatey package. Congrats!

I know that unsolicited advice is rarely welcome, so feel free to reject this and send me insults.

Were I to write this package installer, I would make it an embedded package. That means the zip file is in the tools directory when you create the .nupkg. The license allows for that, and means users only need to download the Chocolatey Package and don't need to reach out to the source location. You will have to include a LICENSE.txt and a VERIFICATION.txt file as well.

If you want see how I did an embedded font package with a zip file look here.

The problem with failing the package when any single font of the collection doesn't install as you are currently doing is that some of the fonts may have installed and Chocolatey doesn't remove them on failure. Then, the machine is sitting with a partial collection of fonts installed that Chocolatey thinks is not there at all. Better is to just notify of failures so the user can reverse what happened and be back to where they were.

IMHO, you should really also include a ChocolateyUninstall.ps1 script with the package. While Chocolatey's built-in auto-uninstaller is pretty good with software using an installer, I'm pretty sure it doesn't do anything with fonts. Thus, a user who has Chocolatey install the font and then attempts to uninstall it, will be in a state where Chocolatey says the font is uninstalled, but it is still actually installed. Again, the Ubuntu package above can show you one way to do it.

Stay healthy!

The package repo points to 2.225, but in Chocolatey the latest published version is 2.002