cisco-open / ansible-collection-catalystwan Goto Github PK

Please describe the problem

Module plugins/modules/software_upgrade.py is doing upgrades which can take quite long time (from minutes to hours).
Currently we do not have any progress bar or stdout information about progress of the upgrade.

Please describe the solution you'd like

Verify if it is possible to incorporate progress bar or any other STDOUT mechanism for notifying users about progress of software upgrades.

Additional context

No response

Summary

check_version_id_exists_in_repository in plugins/modules/software_repository.py should be deprecated.

notes from previous repository:

# TODO enhance checks based on some requirements, because it seems that we have too many options to define version
# TODO - move to filter

Logs and external information

No response

Reproduction script

N/A

Issue Severity

None

Summary

Example in file plugins/module_utils/vmanage_module.py:

result.response = [task.dict() for task in task_result.sub_tasks_data]

Our result should provide task status, not id

Logs and external information

No response

Reproduction script

N/a

Issue Severity

None

Please describe the problem

Ansible Module utils do not provide any mechanism for controlling STDOUT prints for custom written modules. We can scrap verbosity level (from -vvv flags), so we can enhance our custom developers logger now.

But for printing, we have no access to Ansible class Display from utils for Ansible Core. Guess there were reasons why they didn't provide it for the custom modules - but don't know yet why. And don't know how to overcome it easily.

Please describe the solution you'd like

Enable printing STDOUT (like some waiting time, retries etc.)

Additional context

No response

Please describe the problem

Add listed below features.

Please describe the solution you'd like

1. support more parameters than hostname
2. template name
3. idempotence
4. Currently if template with that name exists, we are going to attach it once again to the device.

Additional context

No response

Please describe the problem

Example module should look like:

 - name: Send raw request to vManage
    cisco.catalystwan.request:
        endpoint: "desired endponit"
        payload: "Any dict provided by user, or json, or whatever"
        ...

Please describe the solution you'd like

That requires rethink of handling get/put/post/delete operations, and also payload fetching

Additional context

No response

Please describe the problem

Validate variables with schema.

Please describe the solution you'd like

Can be applied to all inputs that are for modules.

Additional context

No response

Please describe the problem

Now we are adding devices in a loop, type after type. It can be slow for too many devices.

Please describe the solution you'd like

This FR would be considered done if our modules would handle list of devices that will be passed to modules, and it would add them in parallel.

Additional context

No response

Please describe the problem

All of the modules will produce 2 log files: ansible_catalystwan_module.log and catalystwan.log.
Currently base dir destination of these log files will be current working directory of playbooks.

Please describe the solution you'd like

Allow external configuration of log paths within ansible.cfg or other .cfg file.

Additional context

1. Define when log error/info/debug, define message schema, output etc.
   That needs to be perfected in order to let users have meaningful understanding of the modules.

2. Update logger config and let -vvv flags and ansible verbosity to control these levels

    # verbosity = module.module._verbosity

3. Flag to dump catalystwan logs should be set always so users will have access to all log!
4. Verify with export VMNGCLIENT_DEVEL="X" and without
5. Allow usage: `catalystwan_devel=dict(type=str, required=False, allback=(env_fallback, ['VMNGCLIENT_DEVEL']))``

Please describe the problem

Currently when uploading software images we can pass only one image.

Please describe the solution you'd like

software_repository modules, in parameter image_path or image accepts list of images to upload (and upload will happen in parallel)

Additional context

No response

Please describe the problem

Currently in plugins/modules/administration_settings.py under certificates we support only cisco.

Please describe the solution you'd like

Enhance certificates operations with digicert

Additional context

No response