cite-architecture / citablebase.jl Goto Github PK

Since you can't dispatch on strings used in different implementations of Urn

CitableText has conflicting implementations of dropsubref for strings and for CtsUrn types.

IliadRange = CtsUrn("urn:cts:greekLit:tlg0012.tlg001.allen:1.1-1.10")
Iliad_1_1 = CtsUrn("urn:cts:greekLit:tlg0012.tlg001.allen:1.1")
Iliad_1_2 = CtsUrn("urn:cts:greekLit:tlg0012.tlg001.allen:1.2")
Iliad_1_10 = CtsUrn("urn:cts:greekLit:tlg0012.tlg001.allen:1.10")

ursncontains(IliadRange, Iliad_1_2) should return false, because you can't know that without a corpus.

But

ursncontains(IliadRange, Iliad_1_1)
and
ursncontains(IliadRange, Iliad_1_10)

…should return true, because we can know that from the URN itself, without a corpus.

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

• link to ghpages
• explain RL directory and its unit tests

Start from something like this where v is a Vector a w the width of the window.

function nooverlap(v, w=3)
    ln = length(v)
    span = w - 1

   c1 = range(start=1, step = w, stop = ln) |> collect
   c2 = range(start=w, step = w, stop = ln) |> collect
   ln2 = mod(ln, w) == 0 ? length(c1) : length(c1) - 1

   rnglist =  UnitRange.(c1[1:ln2], c2)
   view.(Ref(ns), rnglist)
   # now catch any mods left over, and vcat one more row onto this view
end

• istable
• rows
• columns
• filter
• schema

avoid overlap with abstract type names.

Or more specific "contains" ?

fromcex explicitly names dispatch value. Don't we need to do that elsewhere? Why is dispatch working in documenter pages?

@JuliaRegistrator register branch=main

For a pair of URN objects, this could be equivalent to == but for a collection, could be a filter analogous to urncontains

see notes in wiki

Sending all invocations to same function when they share a trait value?

• subref
• hassubref
• dropsubref
• isrange
• range_begin
• range_end

Why?

Implementation in CitableCorpus is broken: is error in CitableBase?