Giter VIP home page Giter VIP logo

broker_garbage's People

Contributors

ckaotik avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

Forkers

zidomo

broker_garbage's Issues

Latest alpha unusable: fails to detect sellable items properly

(waves to Ckaotik)

Updated from alpha f0ec4be (May 17/11, worked properly the last 3 weeks) to the latest b4908ea (June 1/11). Retained old saved variables. Opened up a vendor with grey items in bag as well as an unusable BOP plate item (on a Druid who has leather as the best armor type usable). None of the items were on the custom "sell" or "keep" lists.

The vendor-sell button did not light up. Mousing over the button, "Nothing to sell!" improperly appears. But then press the button and a couple (but not all) of the greys are sold. As well, the unusable plate item was not sold. The grey not sold was leather shoulders: Fur-Lined Shoulderpads (http://www.wowhead.com/item=33378). Broker Garbage was probably confused with the tested character being a Druid. The BOP plate item that should have been sold but was not: Vigilant Skullcap (http://www.wowhead.com/item=38086).

Reverted back to alpha f0ec4be and restarted, the vendor button properly lit up and all items that were supposed to be sold were sold clicking the button. Including the grey leather shoulders & plate helmet.

So regressions in the latest alphas.

bad argument #1 to 'pairs' (table expected, got nil)

I got this bug today:

Date: 2014-10-11 15:25:21
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Broker_Garbage\util.lua line 90:
bad argument #1 to 'pairs' (table expected, got nil)
Debug:

Broker_Garbage\util.lua:90:
Broker_Garbage\util.lua:86
Broker_Garbage\util.lua:205: CheckSettings()
Broker_Garbage\Broker_Garbage.lua:33: ?()
Broker_Garbage\Broker_Garbage.lua:13:
Broker_Garbage\Broker_Garbage.lua:12
Locals:
(_temporary) = nil
(_temporary) = "table expected, got nil"
= defined =C:-1

AddOns:
Swatter, v4.4.1 (<%codename%>)
WowheadLooter, v60004
Accountant, v5.01.50400
AddOnSkins, v2.959
Altoholic, v5.4.008
Archy, v1.8.44
AskMrRobot, v1.2.16.0
AucAdvanced, v5.20.5464 (RidiculousRockrat)
aucadvancedsearcherpawn, v1.5.2
AucFilterBasic, v5.20.5464 (RidiculousRockrat)
AucFilterOutlier, v5.20.5464.5459(5.20/embedded)
AucMatchUndercut, v5.20.5464.5364(5.20/embedded)
AucStatHistogram, v5.20.5464 (RidiculousRockrat)
AucStatiLevel, v5.20.5464 (RidiculousRockrat)
AucStatPurchased, v5.20.5464 (RidiculousRockrat)
AucStatSales, v5.20.5464.5376(5.20/embedded)
AucStatSimple, v5.20.5464 (RidiculousRockrat)
AucStatStdDev, v5.20.5464 (RidiculousRockrat)
AucStatWOWEcon, v5.20.5464.5323(5.20/embedded)
AucUtilAHWindowControl, v5.20.5464.5347(5.20/embedded)
AucUtilAppraiser, v5.20.5464.5462(5.20/embedded)
AucUtilAskPrice, v5.20.5464.5447(5.20/embedded)
AucUtilAutoMagic, v5.20.5464.5443(5.20/embedded)
AucUtilCompactUI, v5.20.5464.5444(5.20/embedded)
AucUtilEasyBuyout, v5.20.5464.5458(5.20/embedded)
AucUtilFixAH, v5.20.5464 (RidiculousRockrat)
AucUtilItemSuggest, v5.20.5464.5417(5.20/embedded)
AucUtilPriceLevel, v5.20.5464.5458(5.20/embedded)
AucUtilScanButton, v5.20.5464.5403(5.20/embedded)
AucUtilScanFinish, v5.20.5464.5347(5.20/embedded)
AucUtilScanProgress, v5.20.5464.4979(5.20/embedded)
AucUtilScanStart, v5.20.5464.5347(5.20/embedded)
AucUtilSearchUI, v5.20.5464.5452(5.20/embedded)
AucUtilSimpleAuction, v5.20.5464.5452(5.20/embedded)
AucUtilVendMarkup, v5.20.5464.4828(5.20/embedded)
Babylonian, v5.1.DEV.332(/embedded)
BadBoy, v12.400
BeanCounter, v5.20.5464 (RidiculousRockrat)
BittensSpellFlashLibrary, v50400.4.2
BrokerGarbage, v@project-version@
Configator, v5.1.DEV.359(/embedded)
DataStore, v5.4.001
DataStoreCharacters, v5.4.001
DebugLib, v5.1.DEV.337(/embedded)
ElvUI, v6.99995
Enchantrix, v5.20.5464 (RidiculousRockrat)
LibExtraTip, v5.12.DEV.363(/embedded)
Outfitter, v5.9.3
Pawn, v1.8.11
PetTracker, v
PetTrackerJournal, v
SlideBar, v4.4.1 (<%codename%>)
SpellFlash, v6.10
SpellFlashCore, v2.0.4
Stubby, v5.20.5464 (RidiculousRockrat)
TipHelper, v5.12.DEV.351(/embedded)
BlizRuntimeLib_enUS v5.4.8.50400
(ck=8cb)

constants.lua : table index is nil + inconsistent looting messages

Errors at startup, a lot of "WARNING> Updating enUS entry WOW_ITEM_TYPE_GEM with [Gem]" type messages mentioning
item_type_container_enchanting with [enchanting bag], was [engineering bag].
item_type_container_engineering with [engineering bag], was [gem bag]. etc.

Message: ..\AddOns\Broker_Garbage\constants.lua line 138:
table index is nil
Debug:

Broker_Garbage\constants.lua:138: in main chunk

Message: ..\AddOns\Broker_Garbage\util.lua line 368:
attempt to index field 'usableGear' (a nil value)
Debug:

Broker_Garbage\util.lua:368: UpdateCache()
Broker_Garbage\util.lua:460: GetCached()
Broker_Garbage\core.lua:393: ScanInventoryContainer()
Broker_Garbage\core.lua:46:

Broker_Garbage\core.lua:24

Also, in dungeons, when looting something I get repeated 'You can't loot Kibble because you don't have any bag space.
Looted Kibble.
('Kibble' being whatever I loot)

Suggestion: A 'one time sell' list.

I have multiple characters, and all of them were going through the same quests more or less, so they all got the same rewards. Some could use them, some couldn't; like my druid gets some plate BOP pants she can't use, but the paladin takes them to use. If I add them to the sell list, they'll get sold on either character. What I'd like is for the druid to be able to add them to the one-time list so next time she gets to a vendor, the useless item gets sold, but the paladin doesn't inadvertently go naked.

Gotta take the long shot

Sorry in advance for using the issues tracker for this.

I recently got back to wow through Classic and did my best to remember "that one titan panel broker that let me delete loot based on lowest value". Didn't know the name or how to word the searches but after some hours I eventually found it (well, yeah, I'm here :P).
I see you've stopped playing Wow a long time ago, and probably mostly abandoned this project as you did. There's still a glimmer of hope though. A lot of people came back for classic. Perhaps you're one of them?

I tested the addon in classic, and to no surprise it didn't run smoothly (or at all. In fact it broke some other unrelated addons somehow), and was spewing LUA errors left and right.

In short what I'm trying to get at is; Are you back for classic, and if so, will you be picking up this gem of a timesaver again?

I admit, posting this here is a long shot, but every shot not taken is guaranteed to miss. Or something along those lines. Idioms are not my strong suit.

Conflict with Arkinventory

Whenever I loot I get this error:
Message: Interface\AddOns\ArkInventory\ArkInventory.lua:6897: attempt to index local 'frame' (a nil value)
Time: Mon Jul 30 15:59:09 2018
Count: 2
Stack: Interface\AddOns\ArkInventory\ArkInventory.lua:6897: attempt to index local 'frame' (a nil value)
[C]: ?
Interface\AddOns\ArkInventory\ArkInventory.lua:6897: in function Frame_Item_GetDB' Interface\AddOns\Broker_Garbage\externals.lua:221: in function <Interface\AddOns\Broker_Garbage\externals.lua:218> [C]: in function Frame_Item_Update'
...nterface\AddOns\ArkInventory\ArkInventoryStorage.lua:1797: in function `ScanBag_Threaded'
...nterface\AddOns\ArkInventory\ArkInventoryStorage.lua:1556: in function <...nterface\AddOns\ArkInventory\ArkInventoryStorage.lua:1554>

Locals:

Broker_Garbage + Loot Manager + Bagnon sometimes freeze the game

I've noticed a one-second-or-so freezes when use an almost any ability (combat ability or simply summon mount). Error messages at start of the game:

Date: 2013-12-08 17:02:00
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Broker_Garbage\externals.lua line 140:
hooksecurefunc(): SetBorderQuality is not a function
Debug:

Broker_Garbage\externals.lua:140: in main chunk
Locals:

AddOns:
Swatter, v5.18.5433 (PassionatePhascogale)
Bagnon, v5.4.3
BrokerGarbage, v5.1v6release
BlizRuntimeLib_ruRU v5.4.1.50400
(ck=85)


Date: 2013-12-08 17:02:00
ID: 2
Error occured in: Global
Count: 1
Message: ...erface\AddOns\Broker_Garbage-LootManager\options.lua line 346:
attempt to index global 'Broker_Garbage' (a nil value)
Debug:
...erface\AddOns\Broker_Garbage-LootManager\options.lua:346: in main chunk
Locals:
_ = "Broker_Garbage-LootManager"
BGLM =

{
defaultLocalSettings =
{
}
defaultGlobalSettings =
{
}
UpdateLootFrame = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:158
Print = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:21
UpdateSettings_4_1 = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:95
locale =
{
}
Loot = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:189
ShowTooltip = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:119
IsInteresting = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:155
CreateHorizontalRule = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:130
IsPrivateLoot = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:187
SelectiveLooting = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:202
CheckSettings = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:78
Debug = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:27
Set = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:68
DeletePartialStack = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:140
HandleLootCallback = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:119
DeleteCheapestItem = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:227
GetLootConstraint = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:202
privateLootSpells =
{
}
ShouldAutoLoot = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:178
name = "Broker_Garbage-LootManager"
TrimInventory = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:181
CanSkin = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:140
JoinTables = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:103
HideTooltip = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:128
Get = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:72
}
tonumber = defined =C:-1
Options_LootManager = defined @interface\AddOns\Broker_Garbage-LootManager\options.lua:7
(_temporary) = nil
(_temporary) = nil
(_temporary) = nil
(_temporary) = nil
(*temporary) = "attempt to index global 'Broker_Garbage' (a nil value)"

AddOns:
Swatter, v5.18.5433 (PassionatePhascogale)
Bagnon, v5.4.3
BrokerGarbage, v5.1v6release
BrokerGarbageLootManager, v5.1v6release
BlizRuntimeLib_ruRU v5.4.1.50400
(ck=af)


Date: 2013-12-08 17:02:07
ID: 3
Error occured in: Global
Count: 8
Message: ..\AddOns\Broker_Garbage-LootManager\core.lua line 110:
attempt to index global 'Broker_Garbage' (a nil value)
Debug:
Broker_Garbage-LootManager\core.lua:110:
Broker_Garbage-LootManager\core.lua:33
Locals:
self = {
0 =
RESTACK_COMPLETE = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:29
}
event = "UNIT_SPELLCAST_SUCCEEDED"
arg1 = "player"
(_temporary) = nil
(_temporary) = nil
(_temporary) = nil
(_temporary) = nil
(_temporary) = nil
(_temporary) = nil
(_temporary) = nil
(_temporary) = nil
(_temporary) = nil
(_temporary) = nil
(*temporary) = "attempt to index global 'Broker_Garbage' (a nil value)"
addonName = "Broker_Garbage-LootManager"
BGLM =

{
defaultLocalSettings =
{
}
defaultGlobalSettings =
{
}
BoPConfirmation = 0
confirm =
{
}
UpdateLootFrame = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:158
Print = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:21
UpdateSettings_4_1 = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:95
locale =
{
}
DeleteCheapestItem = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:227
Loot = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:189
ShowTooltip = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:119
IsInteresting = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:155
CreateHorizontalRule = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:130
IsPrivateLoot = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:187
SelectiveLooting = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:202
CheckSettings = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:78
Debug = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:27
Set = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:68
DeletePartialStack = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:140
HandleLootCallback = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:119
looted =
{
}
GetLootConstraint = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:202
privateLootSpells =
{
}
ShouldAutoLoot = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:178
name = "Broker_Garbage-LootManager"
TrimInventory = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:181
CanSkin = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:140
JoinTables = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:103
HideTooltip = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:128
Get = defined @interface\AddOns\Broker_Garbage-LootManager\util.lua:72
}
hooksecurefunc = defined =C:-1
InitializePrivateLoot = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:19
MarkSlotAsLooted = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:22
ipairs = defined =C:-1
frame = {
0 =
RESTACK_COMPLETE = defined @interface\AddOns\Broker_Garbage-LootManager\core.lua:29
}
lootRoutine = nil
pairs = defined =C:-1
_G =
{
ActionButton7FlyoutBorder = ActionButton7FlyoutBorder {
}
MultiCastActionButton6Cooldown = MultiCastActionButton6Cooldown {
}
MerchantItem9ItemButtonStock = MerchantItem9ItemButtonStock {
}
GetTrainerServiceTypeFilter = defined =C:-1
UNIT_NAMES_COMBATLOG_TOOLTIP = "Цветовое выделение названий объектов."
UNIT_NAMEPLATES_TYPE_TOOLTIP_3 = "Индикаторы здоровья не накладываются друг на друга, располагаясь горизонтально и вертикально."
SetTrainerServiceTypeFilter = defined =C:-1
SPELL_FAILED_CUSTOM_ERROR_71 = "Этот кутила хочет потанцевать с вами."
RecruitAFriendFrame = RecruitAFriendFrame {
}
CompactUnitFrameProfilesGeneralOptionsFram
AddOns:
Swatter, v5.18.5433 (PassionatePhascogale)
Bagnon, v5.4.3
BrokerGarbage, v5.1v6release
BrokerGarbageLootManager, v5.1v6release
BlizRuntimeLib_ruRU v5.4.1.50400
(ck=af)


Error with ID = 3 occurs every time when I use an ability.

PS Sorry for my English :)

Keep, Junk, Sell lists gone?

The curseforge version has a UI for managing the Keep, Junk, Sell lists, but it seems to be missing in the repo version. Were they removed or am I missing something?

image

Latest May builds do not detect or sell unusable items

Hi ckaotik, nice to see you back (however long it may be) and still coding for this mod :). A big problem with most of the builds from May, though. They don't either recognize or light up the vendor button to sell unusable items on either a Druid or Priest tested.

Builds tested: 22b1afb (May 11/11) and 2ea69e1 (May 13/11). "Sell Unusable Gear" remained checkmarked on from using earlier builds. The new "Outdated Armor" option was unchecked/off as I don't use TopFit. WoW 4.1 live, USEnglish client/server.

Run dungeons on a mid-level (30-40) Druid and a level 85 Priest. Win through greed rolls a few non-usable items on each (plate & mail on druid, unusable weapon & relic on Priest). Head to a vendor. The Broker_Garbage icon to sell things at vendor never lit up with those unusable items in each character's backpacks with either new build.

On the Priest (last tested character), reverted back to the earlier 3671613 (Feb 28/11) Broker_Garbage build that worked properly. The relic was still in backpack. On relogging, the old version properly detected the relic as unusable and could sell it.

So some work still to do for TopFit and/or people not using that mod (I'm not).

Logon error with new alpha

Commit 1f62201 , USEnglish client/server. Log on and the following error is thrown up:

["message"] = "Broker_Garbage-4.0v4\locale\deDE.lua:165: unexpected symbol near '='\n\nLocals:|r\n\n ---",
["type"] = "error",
["time"] = "2010/11/11 19:51:14",
["session"] = 551,
["counter"] = 1,
}, -- [995]

Crashing Wow

Hi, i like this addon but have some problem. It crash wow when i right click on it to open options.
latest version too. No lua errors, no nothing just hang, and some minutes later disconnect.
Or windows says program not responds and ask for close.
ok one more thing, when checking Interface/Addons ingame Broker_garbage is not there.
/thomas

attempt to concatenate local 'reason' (a nil value)

ID: 64
Error occured in: Global
Count: 32
Message: ..\AddOns\Broker_Garbage\util.lua line 69:
   attempt to concatenate local 'reason' (a nil value)
Debug:
   [C]: ?
   Broker_Garbage\util.lua:69: GetReasonInfo()
   Broker_Garbage\display.lua:361:
      Broker_Garbage\display.lua:351
   [C]: SetBagItem()
   ..\FrameXML\ContainerFrame.lua:1149: ContainerFrameItemButton_OnEnter()
   [string "*:OnEnter"]:1:
      [string "*:OnEnter"]:1
Locals:

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.