clavijojuan / l.switchbasemap Goto Github PK

Hi,

First off great work with the plugin.

Plugin works perfect but I wonder if there is anyway to get the layer property of the layer that changed. In example

Lets say we have two layers one for satellite and one for classic street map. Satellite is loaded first and when I changed it to Street map, I need some kind of event trigger with parameters includes layer property of Street map layer config.

I am asking this because I am trying to use this plugin with an another plugin: Leaflet-MiniMap . So I need this event so that I can tell my minimap controller to switch street view as well when I changed the basemap from satellite to street.

Hi @clavijojuan, it's me again 😋

Please consider making the switches (e.g. the <div class="basemapImg">) keyboard focusable and understandable by screen reader users:

• tabindex="0" can be used to make the icons focusable
• role="button" lets users with screen readers know that they can be pressed
• aria-pressed="true|false" lets screen reader users know if the icon is selected or not

Hi!

Please consider

imgContainer.addEventListener('click', (event) =>{
event.stopPropagation();
this._removeLayers(obj.layer);

• if the map is listening for click events, changing the base map (by clicking on the image element, triggers the map click too).

Hi,

Thank you for a very nice plugin. Would it make sense to suppress the other panels appearing when moving the mouse off the control after the first one is selected?

I can see the argument either way but maybe it could be an option?