cleanroommc / betterquesting Goto Github PK

Hey there,

I appreciate having a new option to edit quests and the work that was put into the new editor, but at least using ATLauncher, it's completely broken at the moment.

Upon finishing the quest description, pressing the "done" button just closes the window and doesn't input the text into the game. I've tried this on a fresh install and on my current WIP pack, and both have the same results. So unless I want to write the quests entirely out in the description box without formatting, quest descriptions can't be written with 4.2.0. I haven't seen anything popping up in the logs either.

Aside from that, the new editor doesn't appear to have the ability to preview your text formatting as you work on the quest descriptions anymore. After using the original editor for a while it's definitely a frustrating removal, on top of it just not working in the first place.

Not having an option to switch back to the original in-game editor essentially makes updating from 4.1.0 a no-go.

crash-2022-10-17_14.33.12-client.txt

Based off: https://github.com/tracer4b/nomi-ceu/issues/87

Description:

Clicking the blank box in a choice reward quest's claiming section causes a client crash.

Expected Behavior:

The box either shouldn't be there or should do nothing.

Steps To Reproduce:

Open choice reward quest
Complete said quest
Click the blank box before selecting a reward
The client will crash and display the crash screen.

Crashlog:

---- Minecraft Crash Report ----
// Lolis deobfuscated this stacktrace using MCP's stable-39 mappings.
// Don't do that.

Time: 2022-08-31 16:34:43 EDT
Description: Updating screen events

java.lang.NullPointerException
    at betterquesting.api2.client.gui.panels.content.PanelItemSlot.onButtonClick(PanelItemSlot.java:134)
    at betterquesting.api2.client.gui.controls.PanelButton.onMouseRelease(PanelButton.java:228)
    at betterquesting.api2.client.gui.panels.CanvasMinimum.onMouseRelease(CanvasMinimum.java:122)
    at betterquesting.api2.client.gui.panels.CanvasEmpty.onMouseRelease(CanvasEmpty.java:82)
    at betterquesting.api2.client.gui.panels.lists.CanvasScrolling.onMouseRelease(CanvasScrolling.java:322)
    at betterquesting.api2.client.gui.panels.CanvasEmpty.onMouseRelease(CanvasEmpty.java:82)
    at betterquesting.api2.client.gui.panels.CanvasEmpty.onMouseRelease(CanvasEmpty.java:82)
    at betterquesting.api2.client.gui.panels.CanvasEmpty.onMouseRelease(CanvasEmpty.java:82)
    at betterquesting.api2.client.gui.GuiScreenCanvas.onMouseRelease(GuiScreenCanvas.java:278)
    at betterquesting.client.gui2.GuiQuest.onMouseRelease(GuiQuest.java:228)
    at betterquesting.api2.client.gui.GuiScreenCanvas.handleMouseInput(GuiScreenCanvas.java:185)
    at net.minecraft.client.gui.GuiScreen.handleInput(GuiScreen.java:501)
    at net.minecraft.client.Minecraft.runTick(Minecraft.java:1759)
    at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1098)
    at net.minecraft.client.Minecraft.run(Minecraft.java:3611)
    at net.minecraft.client.main.Main.main(SourceFile:123)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.polymc.impl.OneSixLauncher.invokeMain(OneSixLauncher.java:104)
    at org.polymc.impl.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:175)
    at org.polymc.impl.OneSixLauncher.launch(OneSixLauncher.java:185)
    at org.polymc.EntryPoint.listen(EntryPoint.java:144)
    at org.polymc.EntryPoint.main(EntryPoint.java:74)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Affected screen --
  Screen name: betterquesting.client.gui2.GuiQuest

My modpack recently transitioned to BQu, and I have had multiple reports of teams not being able to share progress on servers.

From looking at past reports on base BQ, it seems like it's an issue in the base version as well.

Is this functionality not part of the mod, or is it a bug?

Removing quest causes the commit to become too large.
This is an example.

To fix it, I suggest using NBTTagCompound keyed by questID instead of NBTTagList.
This changes the format of the quest file(DefaultQuests.json) and breaks forward compatibility.

BQtweaker comes with a function to allow packdevs to link to websites within the questbook, would be useful to have implemented into BQu.

Example:

The completion number above the questline doesn't update when changing the chapter. An example of this happening in Nomifactory:


Once you do something to refresh it (such as toggling view mode), it updates.

Developers frequently want to create a quest that requires A && (B || C) (multiple examples can be found in Nomifactory). Currently, to do this you have to create an intermediary quest.
The current layout is a single array, preRequisites of type questID[], with a tasklogic of type taskType (AND/OR/NAND/NOR/XAND/XOR) governing how to unlock the quest.
I suggest that this be changed to a preRequisites of type taskType[tasks], with tasks being of type taskType[questID|tasks].

A few examples of how this system would look:
0 && 1 = and: { 0, 1 }
0 && (1 || 2) = and: { 0, or: { 1, 2 } }
(0 || 1) && (2 || 3) = and: { or: { 0, 1 }, or: { 2, 3 } }
0 || (1 && (2 || 3)) = or: { 0, and: { 1, or: { 2, 3 } } }

It would be some nice UI polish if the rewards pane could shrink to fit the height of its contents and hide the scrollbar dynamically.

As before, the rewards pane should have a height limit of 50% of the pane and scroll if its contents cannot fit in that space.

Can I use shortcut keys to open the task interface in any GUI?

This is very convenient, rather than closing the GUI and pressing the shortcut key.

Issue: quest autodetection isn't working in version 4.0.5 (also present in at least 4.0.2, have not tested other versions). The detect/submit button is greyed out until I click on it or click anywhere within either box bounded by the scroll bar or "scroll" with the scroll bar (nothing moves because everything is already visible), as you can see in the image below:

the pack is Nomifactory GTCEu 1.3.5. I have a backup of the 1.3 version of the pack where the issue isn't present, and that version of the pack uses version 3.5.329 of the official mod. I can confirm this is not related to edit mode, as I confirmed I was not in that mode (and even turned it on and back off again in hopes that would fix the issue).

EDIT: this issue is also present in Enigmatica 2: Expert, which uses version 3.5.329 of the official mod. So it seems possible that this issue arises somehow when a screen is resized or something else happens to the GUI?

I would like to see if it would be possible to fix a deceptively simple issue I've been having with the Better Questing mod. Me and a friend have been working on a SRP mod pack that utilizes this mod for the purpose of being part shop, part skill tree for each player to level up and gain new abilities and items through.

There unfortunately has been an issue with repeatable quests which are essential for the functionality of the shop. Any quest that is meant to have the ability to be redone indefinitely will be able to be redone as normal in a single player world, but when they are completed in a multiplayer world they do not properly renew. Only the host is free from this issue, all other players in the server can only do the quest once before having to leave and then rejoin to reset their quests.

Some anomalies of note:
1.) Somehow by turning edit mode on in multiplayer and editing any quest in any way, no matter how small or insignificant the change, and then turning edit mode back off again will cause all repeatable quests to renew.

2.) Using the "bq_user refresh" command fixes the issue temporaily, but it must be used to refresh all repeatable quests each time a player wants to complete one again.

Also note that we are using the most recent and up to date version of Better Questing as well as Essentials to connect to one another.

I appreciate any help or feedback and will provide any additional information as requested.

Ive been trying to play the modpack "Multiblock Madness" but every time I click "collect rewards" for a quest, the game crashes.
Log:
crash-2022-08-20_11.00.27-client.txt
Originally, I posted this on the modpacks github page, but they claimed it was just an issue with this mod, and to post it directly here.

Currently, inherited from bqtweaker I guess, this allows you to go back to quest tree with backspace

But either there is no option to rebind this or I can't find it

I would love support for right-click being an option or built-in a-la old HQM, at least from quest details back to tree. Going all the way back to main menu probably wouldn't be useful.

It looks for .nbt files but FTBQ stores in .snbt (at least in the latest version)

When set to view mode you can see quests that are marked as hidden and those marked as visible upon completion, this makes it so those quests are visible to all. This is different to GTNH which only lets you see hidden quests when in edit mode.

On a server I and my friend were unable to join each other's parties, nor even see the invites. Console said nothing was wrong, so I do not know what to do. Any ideas?

https://hastebin.com/opoxapapot.rb

Currently all quests are thrown into 1 json file, which doesn't behave nicely if you want to use git to merge multiple branches.
It would be nice to be able to have separate quest lines in separate json files. It would already be incredibly helpful in a state where quests from different files can't interact with another (dependencies etc.) but are only displayed in as their own chapters in the quest book.

Pack Context: Nomifactory Dev 2582384, manually updated with BQu 4.0.6

As seen below, the Completion numbers are missing from the tab. This occurs on other quest tabs and the commonality appears to be tabs with a large number of quests on them. It works fine on other tabs with fewer quests.