clearcodehq / pytest-mongo Goto Github PK

Hi there,

I have a use case where I will only know the port to a running instance of mongo at runtime (and I'm able to get that via a session-scoped fixture). I would like to be able to tell pytest-mongo to use such a port. By looking at the documentation, it seems that there isn't a supported way of passing the port (or other configuration) to pytest-mongo at runtime. That would really be useful.

A way I can think of providing such a feature is to allow users to override a fixture that will give the configuration necessary. For example:

@pyest.fixture(scope='session')
def pytest_mongo_conf(my, own, required, fixtures, here):
    ... # Get host and port from other fixtures
    # Options defined in the returned dictionary would override their previous (or default) values
    return {
        'host': host,
        'port': port,
    }

What action do you want to perform

It would be great to keep the current version of pytest-mongo still working for 2.7 releases - at least until EOY.

The fix is simple - currently in setup.py there is no version attached to mirakuru - fixing that at 1.1.0 would keep all this working.

What are the results

What are the expected results

Hi all,
I would like to load predefined data in the mongodb, before the tests.
Something like it's explained in this other library for example
https://github.com/mdomke/pytest-mongodb#configuration

I did not find much in the documentation (the readme file in the root of this project).

Thank you in advance :-)

https://github.com/ankane/setup-mongodb

Some MongoDB features such as change streams do not work with standalone instances. In that case a replica set is required. It would be nice if there was an option to start a database as a single-member replica set for being able to use change streams, transactions etc. also in tests.

Here is workaround that I am currently using in most affected projects. As this is required more often, it would be nice if this was part of the pytest-plugin itself:

@pytest.fixture(scope="session")
def mongo_repl_proc(mongo_proc):
    client = pymongo.MongoClient(f"mongodb://{mongo_proc.host}:{mongo_proc.port}")
    client.admin.command("replSetInitiate")
    time.sleep(1)
    return mongo_proc


@pytest.fixture
def mongo(mongo_repl_proc):  # noqa: CCR001
    """
    Provide an empty mongodb client.

    This is a modification of the fixture from pytest-mongo to support replica
    sets. These require returning a client that specifically knows about them.
    """
    client = pymongo.MongoClient(
        f"mongodb://{mongo_repl_proc.host}:{mongo_repl_proc.port}",
        replicaset="rep0",
        tz_aware=True,
        # Ensures that write operations in tests are always visible to subsequent reads
        # without using explicit sessions.
        journal=True,
    )

    # wait for nodes
    while not client.nodes:
        time.sleep(0.1)

    yield client

    # clean the database
    for db_name in client.list_database_names():
        if db_name == "config":
            continue
        database = client[db_name]
        for collection_name in database.list_collection_names():
            collection = database[collection_name]
            # Do not delete any of Mongo system collections
            if (
                collection.name.startswith("system.")
                or collection.name.startswith("oplog.")
                or collection.name.startswith("replset.")
            ):
                continue
            collection.drop()

An in pytest.ini:

mongo_params = --replSet rep0

use Pipfile to manage development dependencies for pytest-postgresql. Change repo structure if needed. (again - see pytest-redis/pytest-mysql for changes that were required)

• Add towncrier configuration (based of off pytest-redis for example)
• Add towncrier to pipenv's Pipfile (will be first file initialisation)
• Add github-action that'll check pr's for the newsfragment file: https://github.com/ClearcodeHQ/pytest-redis/blob/main/.github/workflows/pr-check.yml
• Change pr template to https://github.com/ClearcodeHQ/pytest-redis/blob/main/.github/PULL_REQUEST_TEMPLATE.rst
• recreate newsfragments for changes since last release

I maintain few postgresql and mongodb related applications and due to a testing requirement change I switched all my postgresql tests to utilize either postgresql_proc or postgresql_noproc depending on a cli parameter. I just found out pytest-mongo does not have a noproc factory.

I think, pytest-mongo features should be on par and in sync with pytest-postgresql.

Dependabot couldn't authenticate with https://pypi.python.org/simple/.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

Python 2 reaches EOL by end of the year.

Path.py has a really nice api, however it's use can safely be replace by stdlib limiting the number of dependencies pytest-mongo has

What action do you want to perform

Import and use package using Python 3.5.4 running on Windows.

What are the results

>>> from pytest_mongo import factories                                                                                                                                                           Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\Jackson Clarke\AppData\Local\Programs\Python\Python35\lib\site-packages\pytest_mongo\factories.py", line 25, in <module>
    from mirakuru import TCPExecutor
  File "C:\Users\Jackson Clarke\AppData\Local\Programs\Python\Python35\lib\site-packages\mirakuru\__init__.py", line 24, in <module>
    from mirakuru.output import OutputExecutor
  File "C:\Users\Jackson Clarke\AppData\Local\Programs\Python\Python35\lib\site-packages\mirakuru\output.py", line 30, in <module>
    class OutputExecutor(SimpleExecutor):
  File "C:\Users\Jackson Clarke\AppData\Local\Programs\Python\Python35\lib\site-packages\mirakuru\output.py", line 107, in OutputExecutor
    def _wait_for_output(self, *polls: Tuple[select.poll, IO[Any]]) -> bool:
AttributeError: module 'select' has no attribute 'poll'

What are the expected results

Successful import. Not sure if Python 3.5 is the problem (is it supported?), or Windows. May be similar to github.com/ClearcodeHQ/mirakuru/pull/333.

Issue

The package has redundant dependency from redis package

Possible solution

Remove dependency due to no code using Redis

MongoClient instances can optionally be timezone aware by providing the tz_aware parameter at construction time. It would be nice at least this parameter could be set such that the mongodb fixture returns clients with this (or other options) enabled. In my case, my application that I am testing requires timezone-aware clients and thus I cannot use the fixture right now.