Comments (5)
I think this could be achievable by communicating with dart sass over the embedded sass protocol (its quite powerful and supports things like custom importers) instead of just invoking it using CLI parameters
There also already exists an awesome java binding for this: https://github.com/larsgrefer/dart-sass-java, even already has an importer for webjars that appears to be compatible with how the libsass-maven-plugin works
Switching the actual "sass host" implementation (invoking the cli vs sass embedded) might be a breaking change though and requires a bit more glue code in this plugin (i.e. walking an input dir for .scss/.sass or watching files is not something the embedded protocol supports)
from dart-sass-maven-plugin.
+1 on the suggestion!
from dart-sass-maven-plugin.
Hey, @qsiebers .
Honestly, even though this is possible, that feature you mentioned counts on JSass, which is a Sass compiler itself. I don't envision this plugin as being so powerful as to contain a parser and catch up with the Dart Sass parser itself.
from dart-sass-maven-plugin.
Integrating JSass in this plugin was definitely not my goal :). Rather to find a way to reproduce the functionality.
I understand that it is not an easy to implement enhancement. If I ever find enough time to implement it, I'll submit it as a MR.
from dart-sass-maven-plugin.
First, thank you for offering a new perspective on this problem, @jungm. I really appreciate it.
The change may not be breaking if we introduce an option to use the embedded Sass protocol for those who need it and leave the default implementation as the CLI.
from dart-sass-maven-plugin.
Related Issues (20)
- Build: mvn clean package fails HOT 1
- Watch: Not watching correct directory HOT 13
- [0.2.0] - Null Pointer Exception HOT 9
- Thread Safe and Update HOT 5
- Mark plugins goals as thread-safe, if possible HOT 1
- Update executables with latest Dart Sass release HOT 5
- Option to ignore css Files HOT 5
- File counter may give incorrect results if input folder and output folder are the same and there's at least one css file on the input folder HOT 1
- noSourceMap isn't working HOT 2
- Filename question HOT 1
- As a user I'd like to choose the Dart Sass plugin version and have it downloaded automatically HOT 1
- [enhancement] support maven proxy settings HOT 6
- Use fallback when current version is unavailable HOT 7
- Permission Denied when executing HOT 10
- Add Many-to-Many Mode HOT 5
- Plugin started hanging since version 1.2.0 HOT 14
- Support Linux OSes not built with glibc HOT 3
- Commons IO Incompatibility: Missing AbstractStreamBuilder HOT 19
- Use Release tags instead of plain tags to mark new versions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dart-sass-maven-plugin.