Giter VIP home page Giter VIP logo

Comments (5)

jungm avatar jungm commented on July 21, 2024 1

I think this could be achievable by communicating with dart sass over the embedded sass protocol (its quite powerful and supports things like custom importers) instead of just invoking it using CLI parameters

There also already exists an awesome java binding for this: https://github.com/larsgrefer/dart-sass-java, even already has an importer for webjars that appears to be compatible with how the libsass-maven-plugin works

Switching the actual "sass host" implementation (invoking the cli vs sass embedded) might be a breaking change though and requires a bit more glue code in this plugin (i.e. walking an input dir for .scss/.sass or watching files is not something the embedded protocol supports)

from dart-sass-maven-plugin.

melloware avatar melloware commented on July 21, 2024

+1 on the suggestion!

from dart-sass-maven-plugin.

cleydyr avatar cleydyr commented on July 21, 2024

Hey, @qsiebers .

Honestly, even though this is possible, that feature you mentioned counts on JSass, which is a Sass compiler itself. I don't envision this plugin as being so powerful as to contain a parser and catch up with the Dart Sass parser itself.

from dart-sass-maven-plugin.

qsiebers avatar qsiebers commented on July 21, 2024

Integrating JSass in this plugin was definitely not my goal :). Rather to find a way to reproduce the functionality.

I understand that it is not an easy to implement enhancement. If I ever find enough time to implement it, I'll submit it as a MR.

from dart-sass-maven-plugin.

cleydyr avatar cleydyr commented on July 21, 2024

First, thank you for offering a new perspective on this problem, @jungm. I really appreciate it.

The change may not be breaking if we introduce an option to use the embedded Sass protocol for those who need it and leave the default implementation as the CLI.

from dart-sass-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.