Giter VIP home page Giter VIP logo

Comments (7)

cleydyr avatar cleydyr commented on July 21, 2024 3

Issue fixed on version 1.2.0, already deployed and soon to be published on Maven Central.

from dart-sass-maven-plugin.

melloware avatar melloware commented on July 21, 2024 1

Confirmed its in Maven Central.

from dart-sass-maven-plugin.

cleydyr avatar cleydyr commented on July 21, 2024

Good catch, @BalusC. I'll address this. Thank you.

from dart-sass-maven-plugin.

melloware avatar melloware commented on July 21, 2024

you rock @cleydyr !

from dart-sass-maven-plugin.

cleydyr avatar cleydyr commented on July 21, 2024

The proposed implementation to make this plugin more resilient is to iterate through each release and each release artifact and check if an artifact name matches what's expected (dart-sass-[VERSION]-[OS]-[ARCH].[EXTENSION]). If there's a matching artifact, we'll use its release as the autodetected version.

Note: the results returned by the GitHub API seem to be sorted by the date of the tag/commit [1], though it's not documented on the API doc itself.

The plugin should not fall back to the locally cached version, as the Dart Sass autodetection is intended to be used in environments with an Internet connection [2], which means it's also able to download at least one version with a matching artifact for all supported os-arch combinations (1.68.0 is one such version). Also, if there was a locally cached release to begin with, it would already be used, and the release download wouldn't be attempted.

from dart-sass-maven-plugin.

cleydyr avatar cleydyr commented on July 21, 2024

Closing this now.

from dart-sass-maven-plugin.

BalusC avatar BalusC commented on July 21, 2024

fab

from dart-sass-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.