The moodle-mod_clickview from clickviewapp

moodle-mod_clickview's People

Contributors

Watchers

moodle-mod_clickview's Issues

SQL error on PostgreSQL

Attempting to add a new instance on PostgreSQL gives an error:

Error reading from database

More information about this error
Debug info: ERROR: invalid input syntax for type bigint: ""
SELECT * FROM m_clickview WHERE id = $1
[array (
0 => '',
)]
Error code: dmlreadexception
Stack trace:

    line 486 of /lib/dml/moodle_database.php: dml_read_exception thrown
    line 329 of /lib/dml/pgsql_native_moodle_database.php: call to moodle_database->query_end()
    line 977 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->query_end()
    line 1671 of /lib/dml/moodle_database.php: call to pgsql_native_moodle_database->get_records_sql()
    line 1643 of /lib/dml/moodle_database.php: call to moodle_database->get_record_sql()
    line 1622 of /lib/dml/moodle_database.php: call to moodle_database->get_record_select()
    line 167 of /mod/clickview/mod_form.php: call to moodle_database->get_record()
    line 83 of /mod/clickview/mod_form.php: call to mod_clickview_mod_form->get_thumbnail_html()
    line 214 of /lib/formslib.php: call to mod_clickview_mod_form->definition()
    line 130 of /course/moodleform_mod.php: call to moodleform->__construct()
    line 150 of /course/modedit.php: call to moodleform_mod->__construct()

title field missing from backup api

https://github.com/clickviewapp/moodle-mod_clickview/blob/main/backup/moodle2/backup_clickview_stepslib.php#L41

https://github.com/clickviewapp/moodle-mod_clickview/blob/main/db/install.xml#L18

not sure if that was accidental/intentional?

It's possible to create an activity without selecting a video

It's possible to add an empty ClickView activity. It will render a 0 on the activity view page. We should catch this in the add new activity wizard and on the backend.

Recommend Projects