Giter VIP home page Giter VIP logo

Comments (6)

budu avatar budu commented on August 19, 2024

I've found out the cause of the problem and I'm working on a fix, should be available soon.

from marginalia.

budu avatar budu commented on August 19, 2024

The fix has been commited:

a92588f

The parser was reading comments has if they where forms, so an uneven number of comment in a map would throw an exception. I've changed the way the custom reader extract comments and made it append them to a vector placed inside an atom and returns the reader itself like the default CommentReader. Thus, that should prevent any other similar bugs.

The parser has been improved at the same time to handle nested comments properly, so I've started a discussion on what to do with them:

https://github.com/fogus/marginalia/issues/issue/15

from marginalia.

hugoduncan avatar hugoduncan commented on August 19, 2024

Still seems to fail for me with the same code. A different exception though:

Caused by: java.lang.IndexOutOfBoundsException
at clojure.lang.RT.nthFrom(RT.java:753)
at clojure.lang.RT.nth(RT.java:722)
at marginalia.parser$eval154$fn__155.invoke(parser.clj:101)
at clojure.lang.MultiFn.invoke(MultiFn.java:171)
at marginalia.parser$extract_docstring.invoke(parser.clj:138)
at marginalia.parser$arrange_in_sections.invoke(parser.clj:199)
at marginalia.parser$parse.invoke(parser.clj:218)
at marginalia.parser$parse_file.invoke(parser.clj:224)
at marginalia.core$path_to_doc.invoke(core.clj:125)
at clojure.core$map$fn__3695.invoke(core.clj:2096)
at clojure.lang.LazySeq.sval(LazySeq.java:42)

from marginalia.

budu avatar budu commented on August 19, 2024

OK, totally different bug, a very stupid mistake! It should be much easier to fix tough.

from marginalia.

budu avatar budu commented on August 19, 2024

Here you go Hugo!

30aec7c

I should have kept the original sample! I'll let you close this issue that time.

from marginalia.

hugoduncan avatar hugoduncan commented on August 19, 2024

Thanks for the swift fixes Nicolas. All well now.

from marginalia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.