Comments (6)
I've found out the cause of the problem and I'm working on a fix, should be available soon.
from marginalia.
The fix has been commited:
The parser was reading comments has if they where forms, so an uneven number of comment in a map would throw an exception. I've changed the way the custom reader extract comments and made it append them to a vector placed inside an atom and returns the reader itself like the default CommentReader
. Thus, that should prevent any other similar bugs.
The parser has been improved at the same time to handle nested comments properly, so I've started a discussion on what to do with them:
https://github.com/fogus/marginalia/issues/issue/15
from marginalia.
Still seems to fail for me with the same code. A different exception though:
Caused by: java.lang.IndexOutOfBoundsException
at clojure.lang.RT.nthFrom(RT.java:753)
at clojure.lang.RT.nth(RT.java:722)
at marginalia.parser$eval154$fn__155.invoke(parser.clj:101)
at clojure.lang.MultiFn.invoke(MultiFn.java:171)
at marginalia.parser$extract_docstring.invoke(parser.clj:138)
at marginalia.parser$arrange_in_sections.invoke(parser.clj:199)
at marginalia.parser$parse.invoke(parser.clj:218)
at marginalia.parser$parse_file.invoke(parser.clj:224)
at marginalia.core$path_to_doc.invoke(core.clj:125)
at clojure.core$map$fn__3695.invoke(core.clj:2096)
at clojure.lang.LazySeq.sval(LazySeq.java:42)
from marginalia.
OK, totally different bug, a very stupid mistake! It should be much easier to fix tough.
from marginalia.
Here you go Hugo!
I should have kept the original sample! I'll let you close this issue that time.
from marginalia.
Thanks for the swift fixes Nicolas. All well now.
from marginalia.
Related Issues (20)
- Markdown extension for linking to a function in docstrings and comments HOT 1
- chokes on Clojure 1.7.0 HOT 8
- Marginalia waits a long time for agents to shut down HOT 2
- Every 3rd time I run, I get an exception HOT 3
- Explore the use of Instaparse
- Processing reader conditionals broken HOT 9
- `lein marg` fails when a map value symbol contains a double colon HOT 8
- Incompatibility in matchSymbol with Clojure 1.9.0-beta1 HOT 4
- lein marg fails under clojure 1.9.* HOT 11
- Does not take into account `:source-paths` HOT 1
- Markdown target HOT 4
- :extend-via-metadata in protocols breaks Marginalia HOT 3
- docco url in README.md HOT 1
- Add instructions for `deps.edn` projects HOT 1
- Transfer to clj-commons? HOT 1
- Make [[docstring-links]] into links HOT 1
- [Idea] Respect .gitignore
- Support blocking search engines (support custom <head> content?) HOT 3
- Update the website link in repo's "About" section HOT 1
- [Idea] Ways to style the docs based on metadata on `def`s HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marginalia.