Comments (4)
Hi, I would like to try and make a PR, but it will have to wait till the weekend I suspect ;-).
from cljfx.
Hi!
There is no reason to not support multimethods by default, and adding support seems to be a non-breaking change. Are you interested to make a PR for that? You'll need to modify defaults.clj to make it accept MultiFn
-s in addition to Fn
-s. I can do it too, but first I'll need to find some time to do that.
Meanwhile, you can make your own type->lifecycle
function that checks for multimethods as well:
(require '[cljfx.api :as fx] '[cljfx.lifecycle :as fx.lifecycle])
(defmulti component ::type)
(defmethod component ::label [{:keys [text]}]
{:fx/type :label :text text})
(fx/on-fx-thread
(fx/create-component
{:fx/type :stage
:showing true
:scene {:fx/type :scene
:root {:fx/type :v-box
:children [{:fx/type component
::type ::label
:text "Hello multimethods!"}]}}}
{:fx.opt/type->lifecycle (some-fn
#(when (instance? clojure.lang.MultiFn %)
fx.lifecycle/dynamic-fn->dynamic)
fx/keyword->lifecycle
fx/fn->lifecycle)}))
from cljfx.
I created a PR: #60.
from cljfx.
Great, thanks! I'll have a look — most probably tomorrow.
from cljfx.
Related Issues (20)
- controlsfx, CheckComboBox HOT 7
- depstar is deprecated and archived; switch to tools.build HOT 2
- The example project fails with (UnsupportedOperationException) HOT 6
- Mouseclick and textfield ?
- Support for CheckBoxTreeItem/CheckBoxTreeCell
- Method for adding another context-like property HOT 1
- Runnning examples/e20_markdown_editor results in NullPointerException: HOT 1
- How do I use StyledTextArea or any new class? HOT 2
- Broken encoding for Sanskrit text in WebView HOT 2
- How do I exit the packaged app on window close or menu quit command HOT 2
- Unable to open DISPLAY HOT 4
- Trying to understand the lifecycle again
- Using cljfx with Gradle HOT 2
- Problem using leiningen HOT 2
- how to pass args to constructors HOT 3
- how to set the background of a region HOT 5
- Children: duplicate children added: when using pie-chart and dynamic rendering HOT 3
- Memory reuse with `fx/ext-instance-factory` HOT 5
- behavior of tree cell factory
- Obscure classloader problem in cider HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cljfx.