Comments (8)
michaelklishin
commented on June 21, 2024
I propose native client use both. Feel free to submit a pull request.
from elastisch.
michaelklishin
commented on June 21, 2024
Sorry, "I could not get the tests to run" is not an acceptable argument. See .travis.yml to learn how it's done.
from elastisch.
schmir
commented on June 21, 2024
michael thanks for the pointer to .travis.yml. I suggest you read http://blog.clojurewerkz.org/blog/2013/04/20/how-to-make-your-open-source-project-really-awesome/ :)
The documention on how to run the tests is missing. We just like to get some trivial stuff fixed and the missing documentation makes it harder than it should be.
Is the following output from lein test expected?
Ran 210 tests containing 1338 assertions. 8 failures, 0 errors. Tests failed.
from elastisch.
michaelklishin
commented on June 21, 2024
@schmir it would be more helpful if you contributed said documentation instead of trolling.
No, failures are not expected. CI passes and so do my local runs.
from elastisch.
michaelklishin
commented on June 21, 2024
I probably should write a post on how to report issues in a way that helps maintainers. You did not provide any stack traces or other information about which tests fail.
ElasticSearch's native client has this annoying requirement that the client release should exactly match the ES release you run it against. Otherwise you may (and very likely, will) run into binary protocol compatibility issues.
Are you running the same release as Elastisch uses?
from elastisch.
konradkonrad
commented on June 21, 2024
Hi michael!
Thanks a lot for implementing this. Seems I'm several minutes to late to send my pull request…
(My test issues were due to a non unique clustername, so thanks also for pointing this out in the documentation!)
from elastisch.
schmir
commented on June 21, 2024
Thanks for the documentation.
lein test passes when I run it against an elasticsearch 0.90.3
(single-node) cluster.
If I run it against 0.90.5 I get some errors. I don't believe the
failures happen because of an incompatibility of the binary protocol
used since I get similar results when upgrading the dependency in
project.clj to 0.90.5.
Retrieving org/elasticsearch/elasticsearch/0.90.5/elasticsearch-0.90.5.pom from central
Retrieving org/elasticsearch/elasticsearch/0.90.5/elasticsearch-0.90.5.jar from central
Reflection warning, clj_http/core.clj:147:11 - reference to field close can't be resolved.
Using Clojure version {:major 1, :minor 5, :incremental 1, :qualifier nil}
Reflection warning, clojurewerkz/elastisch/native/conversion.clj:127:9 - call to put can't be resolved.
Reflection warning, clojurewerkz/elastisch/native/conversion.clj:127:9 - call to put can't be resolved.
Reflection warning, clojurewerkz/elastisch/native/conversion.clj:243:54 - reference to field getValue can't be resolved.
Reflection warning, clojurewerkz/elastisch/native/conversion.clj:463:7 - call to stats can't be resolved.
Reflection warning, clojurewerkz/elastisch/native/conversion.clj:796:7 - call to refresh can't be resolved.
Reflection warning, clojurewerkz/elastisch/native/conversion.clj:808:7 - call to refresh can't be resolved.
Sep 25, 2013 1:23:28 PM org.elasticsearch.plugins
INFO: [Eel] loaded [], sites []
lein test clojurewerkz.elastisch.fixtures
lein test clojurewerkz.elastisch.internal.rest-test
lein test clojurewerkz.elastisch.internal.utils-test
lein test clojurewerkz.elastisch.native-api.count-test
lein test clojurewerkz.elastisch.native-api.delete-test
lein test clojurewerkz.elastisch.native-api.facets-test
lein test clojurewerkz.elastisch.native-api.get-test
lein test clojurewerkz.elastisch.native-api.indexing-test
lein test clojurewerkz.elastisch.native-api.indices-test
lein test :only clojurewerkz.elastisch.native-api.indices-test/test-flush-index-with-refresh
ERROR in (test-flush-index-with-refresh) (Reflector.java:53)
Uncaught exception, not in assertion.
expected: nil
actual: java.lang.IllegalArgumentException: No matching method found: refresh for class org.elasticsearch.action.admin.indices.flush.FlushRequest
at clojure.lang.Reflector.invokeMatchingMethod (Reflector.java:53)
clojure.lang.Reflector.invokeInstanceMethod (Reflector.java:28)
clojurewerkz.elastisch.native.conversion$__GT_flush_index_request.invoke (conversion.clj:808)
clojurewerkz.elastisch.native.index$flush.doInvoke (index.clj:122)
clojure.lang.RestFn.invoke (RestFn.java:439)
clojurewerkz.elastisch.native_api.indices_test/fn (indices_test.clj:71)
clojure.test$test_var$fn__7145.invoke (test.clj:701)
clojure.test$test_var.invoke (test.clj:701)
clojure.test$test_all_vars$fn__7149$fn__7156.invoke (test.clj:717)
clojurewerkz.elastisch.fixtures$reset_indexes.invoke (fixtures.clj:16)
clojure.test$compose_fixtures$fn__7139$fn__7140.invoke (test.clj:678)
clojure.test$default_fixture.invoke (test.clj:671)
clojure.test$compose_fixtures$fn__7139.invoke (test.clj:678)
clojure.test$test_all_vars$fn__7149.invoke (test.clj:717)
clojure.test$default_fixture.invoke (test.clj:671)
clojure.test$test_all_vars.invoke (test.clj:713)
clojure.test$test_ns.invoke (test.clj:736)
clojure.core$map$fn__4207.invoke (core.clj:2487)
clojure.lang.LazySeq.sval (LazySeq.java:42)
clojure.lang.LazySeq.seq (LazySeq.java:60)
clojure.lang.Cons.next (Cons.java:39)
clojure.lang.RT.next (RT.java:598)
clojure.core$next.invoke (core.clj:64)
clojure.core$reduce1.invoke (core.clj:896)
clojure.core$reduce1.invoke (core.clj:887)
clojure.core$merge_with.doInvoke (core.clj:2702)
clojure.lang.RestFn.applyTo (RestFn.java:139)
clojure.core$apply.invoke (core.clj:619)
clojure.test$run_tests.doInvoke (test.clj:751)
clojure.lang.RestFn.applyTo (RestFn.java:137)
clojure.core$apply.invoke (core.clj:617)
user$eval87$fn__142$fn__173.invoke (form-init1162413116088527593.clj:1)
user$eval87$fn__142$fn__143.invoke (form-init1162413116088527593.clj:1)
user$eval87$fn__142.invoke (form-init1162413116088527593.clj:1)
user$eval87.invoke (form-init1162413116088527593.clj:1)
clojure.lang.Compiler.eval (Compiler.java:6619)
clojure.lang.Compiler.eval (Compiler.java:6609)
clojure.lang.Compiler.load (Compiler.java:7064)
clojure.lang.Compiler.loadFile (Compiler.java:7020)
clojure.main$load_script.invoke (main.clj:294)
clojure.main$init_opt.invoke (main.clj:299)
clojure.main$initialize.invoke (main.clj:327)
clojure.main$null_opt.invoke (main.clj:362)
clojure.main$main.doInvoke (main.clj:440)
clojure.lang.RestFn.invoke (RestFn.java:421)
clojure.lang.Var.invoke (Var.java:419)
clojure.lang.AFn.applyToHelper (AFn.java:163)
clojure.lang.Var.applyTo (Var.java:532)
clojure.main.main (main.java:37)
lein test clojurewerkz.elastisch.native-api.mappings-test
lein test clojurewerkz.elastisch.native-api.more-like-this-test
lein test clojurewerkz.elastisch.native-api.percolation-test
lein test clojurewerkz.elastisch.native-api.queries.bool-query-test
lein test clojurewerkz.elastisch.native-api.queries.custom-score-query-test
lein test clojurewerkz.elastisch.native-api.queries.field-query-test
lein test clojurewerkz.elastisch.native-api.queries.filtered-query-test
lein test clojurewerkz.elastisch.native-api.queries.flt-field-query-test
lein test clojurewerkz.elastisch.native-api.queries.flt-query-test
lein test clojurewerkz.elastisch.native-api.queries.fuzzy-query-test
lein test clojurewerkz.elastisch.native-api.queries.ids-query-test
lein test clojurewerkz.elastisch.native-api.queries.match-all-query-test
lein test clojurewerkz.elastisch.native-api.queries.mlt-field-query-test
lein test clojurewerkz.elastisch.native-api.queries.mlt-query-test
lein test clojurewerkz.elastisch.native-api.queries.prefix-query-test
lein test clojurewerkz.elastisch.native-api.queries.query-string-query-test
lein test clojurewerkz.elastisch.native-api.queries.range-query-test
lein test clojurewerkz.elastisch.native-api.queries.term-query-test
lein test :only clojurewerkz.elastisch.native-api.queries.term-query-test/test-basic-term-query-over-non-analyzed-usernames
FAIL in (test-basic-term-query-over-non-analyzed-usernames) (term_query_test.clj:49)
expected: (= "4" (-> (doc/search "tweets" "tweet" :query (q/term :username "michaelklishin")) hits-from first :_id))
actual: (not (= "4" "3"))
lein test :only clojurewerkz.elastisch.native-api.queries.term-query-test/test-basic-term-query-over-non-analyzed-usernames
FAIL in (test-basic-term-query-over-non-analyzed-usernames) (term_query_test.clj:49)
expected: (is (= "4" (-> (doc/search "tweets" "tweet" :query (q/term :username "michaelklishin")) hits-from first :_id)))
actual: false
lein test :only clojurewerkz.elastisch.native-api.queries.term-query-test/test-basic-term-query-over-non-analyzed-embedded-fields
FAIL in (test-basic-term-query-over-non-analyzed-embedded-fields) (term_query_test.clj:59)
expected: (= "4" (-> (doc/search "tweets" "tweet" :query (q/term "location.state" "Moscow")) hits-from first :_id))
actual: (not (= "4" "1"))
lein test :only clojurewerkz.elastisch.native-api.queries.term-query-test/test-basic-term-query-over-non-analyzed-embedded-fields
FAIL in (test-basic-term-query-over-non-analyzed-embedded-fields) (term_query_test.clj:59)
expected: (is (= "4" (-> (doc/search "tweets" "tweet" :query (q/term "location.state" "Moscow")) hits-from first :_id)))
actual: false
lein test clojurewerkz.elastisch.native-api.queries.text-query-test
lein test clojurewerkz.elastisch.native-api.queries.wildcard-query-test
lein test clojurewerkz.elastisch.native-api.search-scroll-test
lein test clojurewerkz.elastisch.native-api.search-test
lein test clojurewerkz.elastisch.native-api.update-test
lein test clojurewerkz.elastisch.query-test
lein test clojurewerkz.elastisch.rest-api.bulk-test
lein test clojurewerkz.elastisch.rest-api.count-test
lein test clojurewerkz.elastisch.rest-api.delete-test
lein test clojurewerkz.elastisch.rest-api.facets-test
lein test clojurewerkz.elastisch.rest-api.get-test
lein test clojurewerkz.elastisch.rest-api.indexing-test
lein test clojurewerkz.elastisch.rest-api.indices-test
lein test clojurewerkz.elastisch.rest-api.mappings-test
lein test clojurewerkz.elastisch.rest-api.more-like-this-test
lein test clojurewerkz.elastisch.rest-api.multi-test
lein test clojurewerkz.elastisch.rest-api.percolation-test
lein test clojurewerkz.elastisch.rest-api.queries.bool-query-test
lein test clojurewerkz.elastisch.rest-api.queries.custom-score-query-test
lein test clojurewerkz.elastisch.rest-api.queries.field-query-test
lein test clojurewerkz.elastisch.rest-api.queries.filtered-query-test
lein test clojurewerkz.elastisch.rest-api.queries.flt-field-query-test
lein test clojurewerkz.elastisch.rest-api.queries.flt-query-test
lein test clojurewerkz.elastisch.rest-api.queries.fuzzy-query-test
lein test clojurewerkz.elastisch.rest-api.queries.ids-query-test
lein test clojurewerkz.elastisch.rest-api.queries.match-all-query-test
lein test clojurewerkz.elastisch.rest-api.queries.mlt-field-query-test
lein test clojurewerkz.elastisch.rest-api.queries.mlt-query-test
lein test clojurewerkz.elastisch.rest-api.queries.prefix-query-test
lein test clojurewerkz.elastisch.rest-api.queries.query-string-query-test
lein test clojurewerkz.elastisch.rest-api.queries.range-query-test
lein test clojurewerkz.elastisch.rest-api.queries.term-query-test
lein test :only clojurewerkz.elastisch.rest-api.queries.term-query-test/test-basic-term-query-over-non-analyzed-usernames
FAIL in (test-basic-term-query-over-non-analyzed-usernames) (term_query_test.clj:47)
expected: (= "4" (-> (doc/search "tweets" "tweet" :query (q/term :username "michaelklishin")) hits-from first :_id))
actual: (not (= "4" "3"))
lein test :only clojurewerkz.elastisch.rest-api.queries.term-query-test/test-basic-term-query-over-non-analyzed-usernames
FAIL in (test-basic-term-query-over-non-analyzed-usernames) (term_query_test.clj:47)
expected: (is (= "4" (-> (doc/search "tweets" "tweet" :query (q/term :username "michaelklishin")) hits-from first :_id)))
actual: false
lein test :only clojurewerkz.elastisch.rest-api.queries.term-query-test/test-basic-term-query-over-non-analyzed-embedded-fields
FAIL in (test-basic-term-query-over-non-analyzed-embedded-fields) (term_query_test.clj:57)
expected: (= "4" (-> (doc/search "tweets" "tweet" :query (q/term "location.state" "Moscow")) hits-from first :_id))
actual: (not (= "4" "1"))
lein test :only clojurewerkz.elastisch.rest-api.queries.term-query-test/test-basic-term-query-over-non-analyzed-embedded-fields
FAIL in (test-basic-term-query-over-non-analyzed-embedded-fields) (term_query_test.clj:57)
expected: (is (= "4" (-> (doc/search "tweets" "tweet" :query (q/term "location.state" "Moscow")) hits-from first :_id)))
actual: false
lein test clojurewerkz.elastisch.rest-api.queries.text-query-test
lein test clojurewerkz.elastisch.rest-api.queries.wildcard-query-test
lein test clojurewerkz.elastisch.rest-api.search-scroll-test
lein test clojurewerkz.elastisch.rest-api.search-test
lein test clojurewerkz.elastisch.rest-api.update-test
lein test clojurewerkz.elastisch.test.helpers
Ran 210 tests containing 1338 assertions.
8 failures, 1 errors.
Tests failed.
from elastisch.
michaelklishin
commented on June 21, 2024
I've released 1.3.0-beta3 with this change.
from elastisch.
Related Issues (20)
- Enable the use of Elastic Shield HOT 9
- _version_type ignored in native bulk HOT 2
- Native get-mapping ignores index name in 2-arity version, returns all index mappings HOT 2
- doc link is dead HOT 1
- Node info endpoint HOT 4
- HTTP API nodes stats endpoint - unable to select specific groups of stats
- Support Elasticsearch 6.x (and 5.x to the extent it makes sense) HOT 17
- Delete by query is not working with HTTP (wrong url?) HOT 3
- Index creation failure in Elasticsearch 5.X HOT 1
- Async version of the REST API HOT 5
- Fix Delete By Query for Elasticsearch 5 HOT 4
- rest.index/refresh fails for Elasticsearch 5 HOT 5
- How can i change port number at which the queries are sent? HOT 1
- Update doc string for search HOT 1
- Cannot create a new index HOT 1
- HTTP client should be configured to use {:content-type :json} by default HOT 1
- Support clojure 1.10.0 HOT 6
- 3.0.1 release date? HOT 3
- Elasticsearch 7.x support? HOT 1
- Unable to create index
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elastisch.