Elastisch should use actionGet not get about elastisch HOT 5 CLOSED

Also, to be specific, the methods I'm specifically referring to are clojurewerkz.elastisch.native.document/create and clojurewerkz.elastisch.native.document/put

https://github.com/clojurewerkz/elastisch/blob/master/src/clojurewerkz/elastisch/native/document.clj#L47

from elastisch.

OK, makes sense. Feel free to submit a pull request!

from elastisch.

@michaelklishin see #57 for an initial pass at this. Everything works, but I didn't add any tests specific to this. I'm honestly a little conflicted about how to do that / if it should be.

The correct behavior to test is that the proper exceptions get thrown in some situations (like version errors). But there's places all over that were switched to actionGet, and testing all of them seems a bit off. And at that point it's kind of just testing that the method elastisch is calling is the method ES generally recommends for this these days.

So long story short, in my head I was able to justify not adding additional tests to myself. If you disagree, feel free to say so, and I'll try thinking it through again.

from elastisch.

LGTM. There is no need to test all actions, pick a couple of common cases (e.g. when an index does not exist) and add tests for them. Thank you!

from elastisch.

Cool. I'll test this indirectly as part of #56, since the proper versioning exception is only thrown with the actionGet call

from elastisch.