Giter VIP home page Giter VIP logo

Comments (5)

michaelklishin avatar michaelklishin commented on June 22, 2024

This is because the docs were effectively ported from the HTTP client. AFAIR The Daily Mail folks contributed some performance improvements that involved giving up on clojure.walk/stringify-keys in some places in the native client.

I'd say lets use strings everywhere in the docs. There is no real upside to using keywords. Feel free to submit a pull request.

from elastisch.

michaelklishin avatar michaelklishin commented on June 22, 2024

Another point: HTTP client eventually delegates to clj-http which assumes maps can have keyword keys. ES native client expects string keys.

from elastisch.

aphyr avatar aphyr commented on June 22, 2024

Know a leaky abstraction. Where are the docs? Trying to figure out where to make a PR to.

from elastisch.

aphyr avatar aphyr commented on June 22, 2024

Aha! Another repo. https://github.com/clojurewerkz/elastisch.docs

from elastisch.

aphyr avatar aphyr commented on June 22, 2024

clojurewerkz/elastisch.docs#10

from elastisch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.