Giter VIP home page Giter VIP logo

Comments (10)

clonemeagain avatar clonemeagain commented on June 15, 2024 3

Hmm, that's annoying. I'll have to upgrade and fix it!

from attachment_preview.

corent56 avatar corent56 commented on June 15, 2024 3

Thank you for the quick fix, it's working fine on chrome!

from attachment_preview.

clonemeagain avatar clonemeagain commented on June 15, 2024 1

If you want to test, please use this version: https://github.com/clonemeagain/attachment_preview/archive/1.11.zip or checkout the 1.11 branch.

I'll test it some more, then merge into master.

from attachment_preview.

ramrajone avatar ramrajone commented on June 15, 2024 1

from attachment_preview.

ramrajone avatar ramrajone commented on June 15, 2024

It was working fine in 1.11 rc1, I had tested with PHP Ver. 7.0.33

https://forum.osticket.com/d/93565-attachment-inline-plugin-not-working
Hope it gets updated soon Thank you
while back there were some changes:
https://github.com/clonemeagain/attachment_preview/pull/29/files/eb4ab2dd5c0f705dcee7f9f56c241830ac7ed1cc

from attachment_preview.

clonemeagain avatar clonemeagain commented on June 15, 2024

Hey chief, I'm super busy ATM, started a new job and there's a lot of work on. My last was really easy so I had plenty of spare time to make plugins.
If you can test with error reporting enabled and send me the logs we might be able to diagnose and patch it sooner.
I'm close, had to buy a new PC and it's taking time to rebuild my development environment, apparently windows 10 and docker just do not play nicely. I'll have some time coming up that should be free, so don't hold your breath or anything, but in the next few days I should be able to replicate the issue and start working on it.

from attachment_preview.

ramrajone avatar ramrajone commented on June 15, 2024

from attachment_preview.

ramrajone avatar ramrajone commented on June 15, 2024

It does not generate any errors

image

image

This message I see from working PDF preview plugin on osTicket ver. 1.10.4:
[Deprecation] HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.

compare side by side:
image

let me know steps that I can do and give you more info Thanks

from attachment_preview.

clonemeagain avatar clonemeagain commented on June 15, 2024

Got a quickly hacked up solution, that works for FF & Chrome in 1.11:

Required setting for Firefox: https://support.mozilla.org/en-US/kb/applications-panel-set-how-firefox-handles-files
Chrome has PDF display enabled by default.

from attachment_preview.

clonemeagain avatar clonemeagain commented on June 15, 2024

from attachment_preview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.