Textfile directory option missing from service unit file when set to default about ansible-node-exporter HOT 7 CLOSED

Could you verify if this is also happening in recent version (v0.22.0) of this role?

from ansible-node-exporter.

Yes, just verified the behavior remains when upgrading to v0.22.0

(ansible) 14:25:39:~/setup/linux/playbooks$ ansible-galaxy role list | grep node-exporter
- cloudalchemy.node-exporter, 0.22.0

from ansible-node-exporter.

Ok, I see now what is going on. You need following lines https://github.com/cloudalchemy/ansible-node-exporter/blob/master/defaults/main.yml#L16-L17 in node_exporter_enabled_collectors to specify directory. This doesn't seem like a bug to me, but it is a problematic issue and fairly strange UX. Could you create a PR with a note about it to https://github.com/cloudalchemy/ansible-node-exporter/blob/master/TROUBLESHOOTING.md document?

from ansible-node-exporter.

So the node_exporter_enabled_collectors variable defaults to a value that uses the variable
node_exporter_text_file_dir?
If so, do you agree it would be a good idea to mention that changing the value of node_exporter_text_file_dir
does not have any impact if node_exporter_enabled_collectors is specified, i.e not left to default to using node_exporter_text_file?

I would also suggest mentioning the expected structure of node_exporters_enabled_collectors, since mentioning it as a
role variable makes users (e.g me) change it.

In this part of the README:

I didn't notice the lack of quotes around the elements in the list, but it's subtle.

(I've edited this comment a few times, FYI)

from ansible-node-exporter.

So the node_exporter_enabled_collectors variable defaults to a value that uses the variable
node_exporter_text_file_dir?

yes

I would also suggest mentioning the expected structure of node_exporters_enabled_collectors, since mentioning it as a
role variable makes users (e.g me) change it.

Sounds good to me. We could do it as another subsection of README (another example) or in the table. Could you create a PR?

from ansible-node-exporter.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from ansible-node-exporter.

Done in #182 and updated in 198aaee

from ansible-node-exporter.