cloudflare / ahocorasick Goto Github PK

I recently consumed this module while working on a project. However, since this repository lacked a robust testing and benchmarking module, I created one and I am now looking to share it.

The testing and benchmarking module I implemented ran the algorithm against English, Chinese, and Vietnamese words and phrases.

The algorithm assumes that the dictionary is fixed. I've found that in practical applications it may happen that the user needs to add new strings to the keyword dictionary and have the matching algorithm be able to start matching those on the fly.

This problem has been studied and a modification to the Aho Corasick algorithm to make it support incremental matching has been proposed by Bertrand Meyer in his article "Incremental string matching".

I've made several modifications to the implementation in my fork , among which is adding the possibility to do incremental string matching as described in Bertrand's article.

I'm happy to submit a PR with only the changes related to this.

I've noticed that the implementation doesn't return the index of where keywords were found in text. This forces the user to do another search for the keyword to find its index, while the Aho Corasick algorithm should be able to provide this information for no extra cost.

I've made several modifications to the implementation in my fork https://github.com/issamemari/ahocorasick, among which is making the algorithm return the index the index. I'm happy to submit a PR that includes only the changes related to this.