cnhup / asmprofiler Goto Github PK

What steps will reproduce the problem?
1. Set up a program with fair amount of computations
2. Start profiling

What is the expected output? What do you see instead?
It should run and show the profiling results. Instead I get a "invalid 
floating point operation". My stacktrace have 6 references to 02c52d70 in 
AsmProfiler before it triggers a floating point exception in my code.

What version of the product are you using? On what operating system?
Windows XP

Please provide any additional information below.
It triggers at the same position each time, but at different cycles 
depending on if I delay it some with some breakpoints etc.

MY CODE:
----------
var
  TrampolineGetLastError: function(): DWORD; stdcall;

function InterceptGetLastError(): DWORD; stdcall;
begin
  Result := TrampolineGetLastError() + 1337;
end;

  @TrampolineGetLastError := InterceptCreate(@GetLastError, @InterceptGetLastError);
  MessageBox(0, PWideChar(IntToStr(GetLastError)), 'Test', MB_OK);

  InterceptRemove(@TrampolineGetLastError, @InterceptGetLastError);
  MessageBox(0, PWideChar(IntToStr(GetLastError)), 'Test', MB_OK);
----------

It shows Assertion error =/

There are numerous files to download in the Downloads list; it is unclear, even 
after reading some Wiki pages, which files to download to have the whole 
asmprofiler package.

It would be better to have a single ZIP download of all the files needed to use 
asmprofiler.

AsmProfiler_Sampling.dpr in RawStacksFrame.pas not found.

What steps will reproduce the problem?
1. Compile the attached project
2. Start AsmProfiler_Sampling.exe
3. "Start Profiling"
4. "Select EXE" and select the TestPerf.exe
5. "Start process now"
6. "Start sampling"
7. wait 10 seconds
8. "Stop sampling"
9. "Show results". Note that the file name contains some garbage characters.
10. Switch to the "Results" tab

What is the expected output? What do you see instead?
I expect to see the profiling results, but I see an "Access violation" error 
(see the attached file).

What version of the product are you using? On what operating system?
AsmProfiler_Sampling v1.0.7.13

Please provide any additional information below.

When running Denomo, it doesn't know about ReleaseDC.

The following line needs to be added to THandleHookManager.RegisterHandleTypes 
in DenomoHandleHook.pas:

lGroup.AddFreeHandleHookProc(User32,  'ReleaseDC', fhmtDeleteObject, 2, 1);

What steps will reproduce the problem?
1. install windows 8
2. profile a delphi program with twwquery
3.

What is the expected output? What do you see instead?
the program crashes


What version of the product are you using? On what operating system?
i have only tried it a program created with delphi 2007. on a win7 machine it 
works fine

Please provide any additional information below.
will try to create an small example that have the problem

TframProcesses.actInjectDllExecute prcedure

in

if _uDllInjection.InjectDllToTarget(sDll, C_StartDllInjectionHook, iprocessid) 
then
MessageDlg(Format('"%s" injected',[sDll]), mtInformation, [mbOK], 0)

[DCC エラー] ProcessesFrame.pas(63): E2010 'Cardinal' と 'string' 
には互換性がありません
[DCC エラー] ProcessesFrame.pas(63): E2010 'Pointer' と 'Integer' 
には互換性がありません

please help.

Hi,

Just tried this tool, it looks interesting and useful,


However, on my 22' monitor with a 1080P resolution and Windows system font DPI 
set to 140%,  font size is too small to read....

What steps will reproduce the problem?
1.Click on ShowResults
2.Select Trace Tree tab

What is the expected output? What do you see instead?
Expected: An empty trace tree
Result: List index out of bounds (-1)

What version of the product are you using? On what operating system?
1.1.2
Delphi 6
Windows 7

Please provide any additional information below.

[DCC エラー] mcThreadSampler.pas(457): E2003: 'CallersEBP'

To bundled JclDebug.pas is
  PStackInfo = ^TStackInfo;
  TStackInfo = record
    CallerAddr: TJclAddr;
    Level: DWORD;
    CallerFrame: TJclAddr;
    DumpSize: DWORD;
    ParamSize: DWORD;
    ParamPtr: PDWORD_PTRArray;
    case Integer of
      0:
        (StackFrame: PStackFrame);
      1:
        (DumpPtr: PJclByteArray);
  end;

CallersEBP is not found.

This is not a problem, but is a request. Pleeease add this.

I love your profiler. The graphics are and presentation of the results are 
superb. You've seen me flaunt it on StackOverflow.

But the one thing that AQTime does that asmprofiler does not is to profile 
not just the calls, but every line in selected routines. This is 
invaluable in finding the location in a big routine of the slowdown.

Currently what I do is set up dummy routines, each with a few lines of the 
code of the big routine, so that asmprofiler can time them. But doing so 
is quite cumbersome. 

Of course I realize that asmprofiler's timing methods means it cannot be 
used for microoptimization, but simply knowing how many times each line is 
executed is valuable.

DllTestApp/Unit2.pas is noting found.

best regals.

What steps will reproduce the problem?
1.Run with asm profiler loaded
2.Do action that must be profiled
3.????
4.No profit: clicking the show results button stalls the app indefinitely. 

What is the expected output? What do you see instead?
I expected profile results.
The ProfilerResultViewer doesn't work either (or I don't understand its 
purpose). I select the directory with the .pdbg file but nothing happens.
Also, restarting the app to be profiled and then clicking show results doesn't 
help: it says that there is no .pdbg file.

What version of the product are you using? On what operating system?
1.1.2
Windows 7
Delphi 6

Please provide any additional information below.

= AV with AsmProfiler.dll

What steps will reproduce the problem?
1. find the right kind of computer
2. load the dll

In _uAsmProfiler.pas@~200 after filling up SecondStackPos the code isn't being 
flushed into code page, which can cause (in some computers) to have an AV when 
calling into it. Adding SetPermission fixes it.

= UI shows wrong class/function name

The ClassName and FunctionName extraction should be this:

  function PosCharReverse(ch: Char; const S: string; Offset: Integer): Integer;
  var
    i: integer;
  begin
    Result := 0;
    for i := Min(Length(S), Offset) downto 1 do
      if S[i] = ch then
      begin
        Result := i;
        exit;
      end;
  end;

  function __ExtractClassName(const S: string):string;
  var
    lLast, lPrev: Integer;
  begin
    lLast := PosCharReverse('.', S, Length(S));
    lPrev := PosCharReverse('.', S, lLast - 1);

    if lLast = 0 then
      Result := ''
    else if lPrev = 0 then
      Result := Copy(S, 1, lLast - 1)
    else
      Result := Copy(S, lPrev + 1, lLast - lPrev - 3);
  end;

  function __ExtractFunctionName(const S: string):string;
  var
    lLast: Integer;
  begin
    lLast := PosCharReverse('.', S, Length(S));
    Result := Copy(S, lLast + 1, Length(S));
  end;

What steps will reproduce the problem?
1. Get source coe from SVN at revision 149
2. Open ProfilerGroup.bpg in Delphi2007 (latest patch)
3. Build all projects

What is the expected output? What do you see instead?
It does not build succesfully, 7 errors saying "Undeclared 
identifier 'PeMapImgNtHeaders'" in JclDebug.pas

What version of the product are you using? On what operating system?
Delphi2007 for Win32, AsmProfiler from SVN at revision 149

Please provide any additional information below.
What do I need to compile ?

What steps will reproduce the problem?
1. go to the front page as if you're a new user
2. read the text, get excited, and click on the download link

What is the expected output? What do you see instead?
Expected to get the latest version (1.1.13)
Instead, I got version, not know that a newer version exists. (1.1.12)

Please provide any additional information below.

This is what triggered me to report this as an issue:
version 1.1.12 was downloaded 1276 times since oct 2012
version 1.1.13 was downloaded 100 times since nov 2012

What steps will reproduce the problem?
1.Add AsmProfiler (from Demo) code to own dpr
2.Compile
3.Run

What is the expected output? What do you see instead?
An Integer overflow dialog is shown the moment the AsmProfiler dll is loaded 
(initialized).
It returns a seemingly valid handle because the proc addresses are retrieved 
successfully.

After that an access violation and an IO error are shown.

The ProfilerForm is shown eventually but it is not accessable.

What version of the product are you using? On what operating system?
ASmProfiler v1.1.2
Windows 7
Delphi 6

Please provide any additional information below.