Giter VIP home page Giter VIP logo

Comments (10)

williscool avatar williscool commented on July 17, 2024 1

0 mentions of hardware_affinity as of today

image

so lgtm

from testsuite.

lixuna avatar lixuna commented on July 17, 2024

What we currently call the hardware workload test category: hardware_affinity

What I would like to see instead:

  • I would expect the workload test category to be called hardware_and_scheduling
  • This is based on #327, where the platform test category is called platform:hardware_and_scheduling

from testsuite.

lixuna avatar lixuna commented on July 17, 2024

Please add your estimate in points (0,1,2,3,5,8,13,21) in the comments below

from testsuite.

wvwatson avatar wvwatson commented on July 17, 2024

2 points

from testsuite.

nupejosh avatar nupejosh commented on July 17, 2024

I've confirmed that all references to hardware_affinity has now been changed to hardware_and_scheduling, but I may not be getting the expected behavior.
crystal src/cnf-conformance.cr hardware_affinity
Screen Shot 2020-11-10 at 9 41 48 AM

I'm able to get the following response when I run
crystal src/cnf-conformance.cr platform:hardware_and_scheduling
Screen Shot 2020-11-10 at 9 39 30 AM

However, I'm not able to receive a proper response when I run
crystal src/cnf-conformance.cr hardware_and_scheduling
Screen Shot 2020-11-10 at 9 40 57 AM

Does AC require the hardware_and_scheduling command to work without the platform prefix?
@lixuna @taylor @wavell @denverwilliams

from testsuite.

lixuna avatar lixuna commented on July 17, 2024

@nupejosh this command is for workload tests, do you need to add the prefix workload?

I'm noticing that this issue does not have A/C on expected behavior and how to test. I'll add the steps from #402 in a comment below

from testsuite.

nupejosh avatar nupejosh commented on July 17, 2024

@lixuna ok cool, I'll standby for AC.. I'm not sure if we need to add the prefix. If so, we should update the docs. I was going by the command in the initial "What I would like to see" section above. and the docs here https://github.com/cncf/cnf-conformance/blob/master/USAGE.md#hardware-resources-and-scheduling-tests

from testsuite.

lixuna avatar lixuna commented on July 17, 2024

Acceptance Criteria for peer review (https://github.com/cncf/cnf-conformance/issues/402#issuecomment-708526547)

--

Documentation is updated:

Common steps

  • Find or create a K8s cluster to use
    • Talk with team for access to an existing cluster
    • Kind K8s clusters will work as well
  • Set the KUBECONFIG environment variable for accessing the target K8s cluster
  • As a developer, Pull down latest version of CNF conformance test code from {FEATURE} branch
    • Check that {FEATURE} Branch passes all A/C
    • Check that {FEATURE} Branch passes tests in Travis CI
  • As a peer reviewer, check that PR passes Travis CI tests
    • if yes, merge PR to master
    • if no, make a comment and request that developer make changes to pass tests
  • As a peer reviewer, Pull down latest version of CNF conformance test code from master branch
  • Run shards install

Spec test should pass

  • Run crystal spec
  • I expect to see PASSED for the tests

Update Prerequisite checker

  • N/A

Update example CNFs cnf-conformance.yml, if needed

  • N/A

Update yml validator, if needed

  • N/A

I would expect the CoreDNS CNF to pass the ip address test when I run the category tests: (hardware_and_scheduling)

  • Follow common steps above, if you have not done so already
  • Run ./cnf-conformance setup, if you have not done so already
  • Run ./cnf-conformance hardware_and_scheduling
  • I expect to see the output from the test
  • I expect to see PASSED for the test

Screenshots of workload test category command output

  • I can see a screenshot of all command for A/C above
  • I can see a screenshot of hardware_and_scheduling category command for A/C above

from testsuite.

lixuna avatar lixuna commented on July 17, 2024

@nupejosh as far as I can see, we do not have any tests in this test category. I am not sure what it should look like when you run a test category name that does not include tests yet. @wavell what was your experience in running this renamed test category?

from testsuite.

wvwatson avatar wvwatson commented on July 17, 2024

image
There are no hardware and scheduling tests for workload yet. Only for platform (the oci runtime test)
@lixuna @nupejosh

from testsuite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.