Comments (10)
0 mentions of hardware_affinity
as of today
so lgtm
from testsuite.
What we currently call the hardware workload test category: hardware_affinity
What I would like to see instead:
- I would expect the workload test category to be called
hardware_and_scheduling
- This is based on #327, where the platform test category is called
platform:hardware_and_scheduling
from testsuite.
Please add your estimate in points (0,1,2,3,5,8,13,21) in the comments below
from testsuite.
2 points
from testsuite.
I've confirmed that all references to hardware_affinity has now been changed to hardware_and_scheduling, but I may not be getting the expected behavior.
crystal src/cnf-conformance.cr hardware_affinity
I'm able to get the following response when I run
crystal src/cnf-conformance.cr platform:hardware_and_scheduling
However, I'm not able to receive a proper response when I run
crystal src/cnf-conformance.cr hardware_and_scheduling
Does AC require the hardware_and_scheduling
command to work without the platform
prefix?
@lixuna @taylor @wavell @denverwilliams
from testsuite.
@nupejosh this command is for workload tests, do you need to add the prefix workload?
I'm noticing that this issue does not have A/C on expected behavior and how to test. I'll add the steps from #402 in a comment below
from testsuite.
@lixuna ok cool, I'll standby for AC.. I'm not sure if we need to add the prefix. If so, we should update the docs. I was going by the command in the initial "What I would like to see" section above. and the docs here https://github.com/cncf/cnf-conformance/blob/master/USAGE.md#hardware-resources-and-scheduling-tests
from testsuite.
Acceptance Criteria for peer review (https://github.com/cncf/cnf-conformance/issues/402#issuecomment-708526547)
--
Documentation is updated:
- https://github.com/cncf/cnf-conformance/blob/master/USAGE.md#hardware-resources-and-scheduling-tests
Common steps
- Find or create a K8s cluster to use
- Talk with team for access to an existing cluster
- Kind K8s clusters will work as well
- Set the KUBECONFIG environment variable for accessing the target K8s cluster
- As a developer, Pull down latest version of CNF conformance test code from {FEATURE} branch
- Check that {FEATURE} Branch passes all A/C
- Check that {FEATURE} Branch passes tests in Travis CI
- As a peer reviewer, check that PR passes Travis CI tests
- if yes, merge PR to master
- if no, make a comment and request that developer make changes to pass tests
- As a peer reviewer, Pull down latest version of CNF conformance test code from
master
branch - Run
shards install
Spec test should pass
- Run
crystal spec
- I expect to see PASSED for the tests
Update Prerequisite checker
- N/A
Update example CNFs cnf-conformance.yml, if needed
- N/A
Update yml validator, if needed
- N/A
I would expect the CoreDNS CNF to pass the ip address test when I run the category tests: (hardware_and_scheduling)
- Follow common steps above, if you have not done so already
- Run
./cnf-conformance setup
, if you have not done so already - Run
./cnf-conformance hardware_and_scheduling
- I expect to see the output from the test
- I expect to see PASSED for the test
Screenshots of workload test category command output
- I can see a screenshot of all command for A/C above
- I can see a screenshot of
hardware_and_scheduling
category command for A/C above
from testsuite.
@nupejosh as far as I can see, we do not have any tests in this test category. I am not sure what it should look like when you run a test category name that does not include tests yet. @wavell what was your experience in running this renamed test category?
from testsuite.
There are no hardware and scheduling tests for workload yet. Only for platform (the oci runtime test)
@lixuna @nupejosh
from testsuite.
Related Issues (20)
- [BUG] github actions fail frequently on cluster delete
- [MAINTENANCE] Create automation for github self-hosted runner deployment
- [MAINTENANCE] Enable github actions to be (successfully) run for PRs created from forked repos HOT 2
- Container ready status clarification during sig_term_handled check HOT 2
- [BUG] Add validate_config in USAGE.md HOT 1
- [BUG] Add process_search in USAGE.md HOT 1
- [BUG] Unstable 5G tests(suci_enabled) in github actions HOT 1
- [MAINTENANCE] Evaluate the necessity of samples included in old PR
- [MAINTENANCE] Jaeger components should not be installed into default namespace
- [BUG] Add operator_installed in USAGE.md HOT 3
- [BUG] Remove the redundancy of the "increase_decrease_capacity" tasks HOT 2
- [BUG] Relocation of the "alpha_k8s_apis" task HOT 1
- [BUG] shared_database2 spec test has inconsistent results in actions
- [BUG] reasonable_image_size passing in GH actions but probably falsely HOT 3
- [BUG] spec tests don't fail on unsuccessful cnf-setup HOT 1
- [Improvement] Optimize runtime of single_process_type test
- [Improvement] Refactor K8sTshark module
- Document TSC Decision for PR Approval
- [Feature] Request to support multiple Helm Charts in CNTI Test Catalog
- [Feature] Drop or rework k8s_netstat library
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from testsuite.