Giter VIP home page Giter VIP logo

critics's People

Contributors

coagulant avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar

Forkers

khramtsoff hoettle genkido aamirabro pedaling ozoli arthurbarros hulab webclinic017

critics's Issues

Crash when trying to run demo mode

I have tried to run demo as in the README (python3.7 & macos):

[2018-08-30 13:00:31] Languages: Slovak
[2018-08-30 13:00:31] Tracking IOS apps: 556540446
Traceback (most recent call last):
File "./usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/bin/critics", line 11, in
load_entry_point('critics', 'console_scripts', 'critics')()
File "/Users/marx/GIT/scraping/critics/critics/init.py", line 9, in main
return cli(auto_envvar_prefix=envvar_prefix)
File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/click-6.7-py3.7.egg/click/core.py", line 722, in call
return self.main(*args, **kwargs)
File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/click-6.7-py3.7.egg/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/click-6.7-py3.7.egg/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/click-6.7-py3.7.egg/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/Users/marx/GIT/scraping/critics/critics/commands.py", line 75, in cli
itunes.start()
File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/tornado-5.1-py3.7-macosx-10.13-x86_64.egg/tornado/ioloop.py", line 1209, in start
self._schedule_next()
File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/tornado-5.1-py3.7-macosx-10.13-x86_64.egg/tornado/ioloop.py", line 1237, in _schedule_next
self._update_next(self.io_loop.time())
File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/tornado-5.1-py3.7-macosx-10.13-x86_64.egg/tornado/ioloop.py", line 1244, in _update_next
callback_time_sec *= 1 + (self.jitter * (random.random() - 0.5))
TypeError: unsupported operand type(s) for *: 'AsyncIOMainLoop' and 'float'

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 25: ordinal not in range(128)

I am facing some asci unicode issue while running this. I was working before and dont have any changes in code. Some how can't figure out which of my setting is out.

This is the stack trace I am getting while running it.

File "/usr/local/bin/critics", line 9, in <module> load_entry_point('critics==0.3.0', 'console_scripts', 'critics')() File "/Library/Python/2.7/site-packages/critics-0.3.0-py2.7.egg/critics/__init__.py", line 9, in main return cli(auto_envvar_prefix=envvar_prefix) File "/Library/Python/2.7/site-packages/click-6.6-py2.7.egg/click/core.py", line 716, in __call__ return self.main(*args, **kwargs) File "/Library/Python/2.7/site-packages/click-6.6-py2.7.egg/click/core.py", line 695, in main with self.make_context(prog_name, args, **extra) as ctx: File "/Library/Python/2.7/site-packages/click-6.6-py2.7.egg/click/core.py", line 620, in make_context self.parse_args(ctx, args) File "/Library/Python/2.7/site-packages/click-6.6-py2.7.egg/click/core.py", line 870, in parse_args opts, args, param_order = parser.parse_args(args=args) File "/Library/Python/2.7/site-packages/click-6.6-py2.7.egg/click/parser.py", line 267, in parse_args self._process_args_for_options(state) File "/Library/Python/2.7/site-packages/click-6.6-py2.7.egg/click/parser.py", line 293, in _process_args_for_options self._process_opts(arg, state) File "/Library/Python/2.7/site-packages/click-6.6-py2.7.egg/click/parser.py", line 414, in _process_opts self._match_long_opt(norm_long_opt, explicit_value, state) File "/Library/Python/2.7/site-packages/click-6.6-py2.7.egg/click/parser.py", line 324, in _match_long_opt raise NoSuchOption(opt, possibilities=possibilities) File "/Library/Python/2.7/site-packages/click-6.6-py2.7.egg/click/exceptions.py", line 146, in __init__ UsageError.__init__(self, message, ctx) File "/Library/Python/2.7/site-packages/click-6.6-py2.7.egg/click/exceptions.py", line 38, in __init__ ClickException.__init__(self, message) File "/Library/Python/2.7/site-packages/click-6.6-py2.7.egg/click/exceptions.py", line 14, in __init__ message = message.encode('utf-8') UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 25: ordinal not in range(128)

Let me know if you need any extra info and and please ignore my python skills :)

AttributeError: 'NoneType' object has no attribute 'months' 

ERROR:tornado.application:Exception in callback <functools.partial object at 0x809e85680>
Traceback (most recent call last):
  File "/home/critics/workspace/env/lib/python2.7/site-packages/tornado/ioloop.py", line 1039, in _run
    return self.callback()
  File "/usr/home/critics/workspace/env/src/critics/critics/core.py", line 40, in poll_store
    self.poll_store_single_app(platform, app_id, language, notify)
  File "/usr/home/critics/workspace/env/src/critics/critics/core.py", line 69, in poll_store_single_app
    self.send_messages(new_reviews, platform, notify)
  File "/usr/home/critics/workspace/env/src/critics/critics/core.py", line 81, in send_messages
    self.notifiers['slack'](new_reviews, self.settings['slack_webhook'], channel)
  File "/usr/home/critics/workspace/env/src/critics/critics/transport.py", line 70, in post2slack
    } for review in reviews],
  File "/usr/home/critics/workspace/env/src/critics/critics/transport.py", line 45, in get_date_string
    return format_datetime(date, 'd MMMM yyyy hh:mm', locale=get_locale())
  File "/home/critics/workspace/env/lib/python2.7/site-packages/babel/dates.py", line 618, in format_datetime
    return parse_pattern(format).apply(datetime, locale)
  File "/home/critics/workspace/env/lib/python2.7/site-packages/babel/dates.py", line 907, in apply
    return self % DateTimeFormat(datetime, locale)
  File "/home/critics/workspace/env/lib/python2.7/site-packages/babel/dates.py", line 904, in __mod__
    return self.format % other
  File "/home/critics/workspace/env/lib/python2.7/site-packages/babel/dates.py", line 929, in __getitem__
    return self.format_month(char, num)
  File "/home/critics/workspace/env/lib/python2.7/site-packages/babel/dates.py", line 998, in format_month
    return get_month_names(width, context, self.locale)[self.value.month]
  File "/home/critics/workspace/env/lib/python2.7/site-packages/babel/dates.py", line 195, in get_month_names
    return Locale.parse(locale).months[context][width]
AttributeError: 'NoneType' object has no attribute 'months'

Crash when app has no reviews

When trying to fetch reviews for an app and an language where the number of reviews is currently 0, critics crashes with the following stack trace:
Traceback (most recent call last): File "/usr/local/bin/critics", line 9, in <module> load_entry_point('critics==0.3.0', 'console_scripts', 'critics')() File "/usr/local/lib/python2.7/dist-packages/critics-0.3.0-py2.7.egg/critics/__init__.py", line 9, in main return cli(auto_envvar_prefix=envvar_prefix) File "/usr/local/lib/python2.7/dist-packages/click-6.7-py2.7.egg/click/core.py", line 722, in __call__ return self.main(*args, **kwargs) File "/usr/local/lib/python2.7/dist-packages/click-6.7-py2.7.egg/click/core.py", line 697, in main rv = self.invoke(ctx) File "/usr/local/lib/python2.7/dist-packages/click-6.7-py2.7.egg/click/core.py", line 895, in invoke return ctx.invoke(self.callback, **ctx.params) File "/usr/local/lib/python2.7/dist-packages/click-6.7-py2.7.egg/click/core.py", line 535, in invoke return callback(*args, **kwargs) File "/usr/local/lib/python2.7/dist-packages/critics-0.3.0-py2.7.egg/critics/commands.py", line 82, in cli app.poll_store('android', notify=notify) File "/usr/local/lib/python2.7/dist-packages/critics-0.3.0-py2.7.egg/critics/core.py", line 41, in poll_store self.poll_store_single_app(platform, app_id, language, notify) File "/usr/local/lib/python2.7/dist-packages/critics-0.3.0-py2.7.egg/critics/core.py", line 55, in poll_store_single_app limit=self.settings.get('parse_max_entries', None)) File "/usr/local/lib/python2.7/dist-packages/critics-0.3.0-py2.7.egg/critics/parsers.py", line 79, in get_android_reviews doc = html.fromstring(response_as_html.encode('utf-8'), parser=utf8_parser) File "/usr/local/lib/python2.7/dist-packages/lxml/html/__init__.py", line 876, in fromstring doc = document_fromstring(html, parser=parser, base_url=base_url, **kw) File "/usr/local/lib/python2.7/dist-packages/lxml/html/__init__.py", line 762, in document_fromstring value = etree.fromstring(html, parser, **kw) File "src/lxml/lxml.etree.pyx", line 3213, in lxml.etree.fromstring (src/lxml/lxml.etree.c:79010) File "src/lxml/parser.pxi", line 1848, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:118341) File "src/lxml/parser.pxi", line 1736, in lxml.etree._parseDoc (src/lxml/lxml.etree.c:117021) File "src/lxml/parser.pxi", line 1102, in lxml.etree._BaseParser._parseDoc (src/lxml/lxml.etree.c:111265) File "src/lxml/parser.pxi", line 595, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:105109) File "src/lxml/parser.pxi", line 706, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:106817) File "src/lxml/parser.pxi", line 646, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:105963) File "<string>", line 0 lxml.etree.XMLSyntaxError

TypeError, number of arguments passed is too high

Current configuration
OS: Ubuntu 16.04

When trying to run critics for testing or for live, this error occurs.
Not using partial() for setting itunes or google_play in cli() while providing a slack_webhook returns the same error, but reviews (if any) are sent to slack.

Traceback (most recent call last):
File "/home/loic/github/crit/bin/critics", line 11, in
sys.exit(main())
File "/home/loic/github/crit/lib/python3.5/site-packages/critics/init.py", line 9, in main
return cli(auto_envvar_prefix=envvar_prefix)
File "/home/loic/github/crit/lib/python3.5/site-packages/click/core.py", line 722, in call
return self.main(*args, **kwargs)
File "/home/loic/github/crit/lib/python3.5/site-packages/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/home/loic/github/crit/lib/python3.5/site-packages/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/loic/github/crit/lib/python3.5/site-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/home/loic/github/crit/lib/python3.5/site-packages/critics/commands.py", line 67, in cli
1000 * settings['beat'], loop)
TypeError: __ init __() takes 3 positional arguments but 4 were given

Default locale unavailable 

Traceback (most recent call last):
  File "/home/critics/workspace/env/bin/critics", line 11, in <module>
    sys.exit(main())
  File "/home/critics/workspace/env/lib/python2.7/site-packages/critics/__init__.py", line 9, in main
    return cli(auto_envvar_prefix=envvar_prefix)
  File "/home/critics/workspace/env/lib/python2.7/site-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/home/critics/workspace/env/lib/python2.7/site-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/home/critics/workspace/env/lib/python2.7/site-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/critics/workspace/env/lib/python2.7/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/home/critics/workspace/env/lib/python2.7/site-packages/critics/commands.py", line 42, in cli
    settings = setup_languages(settings)
  File "/home/critics/workspace/env/lib/python2.7/site-packages/critics/commands.py", line 96, in setup_languages
    settings['language'] = [default_locale()[:2]]
TypeError: 'NoneType' object has no attribute '__getitem__'

Language is not the same as store

  • figure out what are ids of all stores (Apple/Google)
  • make sure we support all of them, even if language name does not match store name

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.