Describe the bug

When extending the ZendeskClient, the makeRequest method fails to return the appropriate API call error.

Your minimal, reproducible example

none

Steps to reproduce

1. Instantiate a client derived from ZendeskClient
2. Intentionally trigger an error in your API request, such as by passing an incorrect parameter.
3. Attempt to capture the error message using the catch method

Expected behavior

As a developer, I'd like if the makeRequest method relayed the error that my client's API returned.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

• OS[Ubuntu: 20.04]
• Typescript[4.9.5]
• React[18.2.0]

Package version

v1.4.0

Additional context

No response

Discussed in #82

it('should throw ZendeskRequestError error on fail', async () => {
    mockZendeskClient.request.mockRejectedValueOnce({
      status: 400,
      responseJSON: { message: 'Request failed' }
    });

    const auth = new BearerAuthZendesk({
      zafClient: mockZendeskClient,
      baseUrl: 'http://localhost',
      endpoint: '/auth',
      bearer: {
        headers: {
          Authorization: 'Basic 123'
        }
      }
    });
    try {
      await auth.getToken();
    } catch (error) {
      expect(error.message).toEqual('Request failed');
    }
  });

it('should throw ZendeskRequestError error on fail', async () => {
    mockZendeskClient.request.mockRejectedValueOnce({
      status: 400,
      responseJSON: { message: 'Request failed' }
    });

    const auth = new BearerAuthZendesk({
      zafClient: mockZendeskClient,
      baseUrl: 'http://localhost',
      endpoint: '/auth',
      bearer: {
        headers: {
          Authorization: 'Basic 123'
        }
      }
    });
  
     await expect(auth.getToken()).rejects.toEqual({
        message: 'Request failed',
        status: 400
     });
  });

Describe the bug

No método make request do zendesk client, deveria ser possível configurar o secure e o timeout para uma requisição específica.

Your minimal, reproducible example

none

Steps to reproduce

none

Expected behavior

Como desenvolvedora, gostaria de poder passar o timeout e o secure como parâmetro quando estou usando o método make request do zendesk.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

• Node version 20.5.1
• React version 18.2.0
• Typescript version 4.9.5

Package version

v1.4.0

Additional context

No response

Describe the bug

Ao definir uma classe derivada da interface AuthBasic e injetá-la no ClientBasic a autenticação não é realizada corretamente, isso porque o authProvider está sendo passado diretamente na opção de Proxy do Axios, fazendo com que o pacote não execute corretamente qualquer tipo de autenticação (com exceção da Basic Auth sem estar encapsulada por um authProvider).

Your minimal, reproducible example

No response

Steps to reproduce

1. Importe o ClientBasic.
2. Crie um client qualquer que necessite qualquer tipo de autenticação e extenda o ClientBasic.
3. No construtor do novo cliente, na propriedade authProvider injete qualquer tipo de AuthBasic.
4. Instancie o cliente e execute qualquer método que requeira autenticação.

Expected behavior

Como desenvolvedor esperava poder definir diferentes estratégias para autenticação de acordo com a API que esteja integrando, porém a única estratégia de autenticação disponível é via Basic Auth, utiilizando ainda as opções de Proxy do Axios e não do Provider interno do pacote.

How often does this bug happen?

Every time

Screenshots or Videos

Cliente de Tickets utilizando autenticação base a partir do provedor interno do pacote BasicAuth.

import { BasicAuth, ClientBasic } from '@coaktion/client-core';

export class TicketsClient extends ClientBasic {
  constructor(baseUrl: string) {
    super(baseUrl, {
      appName: 'tickets-client',
      endpoints: {
        search: '/tickets',
      },
      authProvider: new BasicAuth({
        username: '[email protected]',
        password: 'Aktie@2021!'
      })
    });
  }
}

Cliente de Tickets utilizando autenticação base a partir do Proxy do Axios.

import { ClientBasic } from '@coaktion/client-core';

export class TicketsClient extends ClientBasic {
  constructor(baseUrl: string) {
    super(baseUrl, {
      appName: 'tickets-client',
      endpoints: {
        search: '/tickets'
      },
      authProvider: {
        username: '[email protected]',
        password: 'Aktie@2021!'
      }
    });
  }
}

Platform

• OS: Windows Sub-System for Linux (Ubuntu 20.04)
• Node: 18.12.0
• TypeScript: 4.9.4

Package version

v1.1.2

Additional context

Atualmente o ClientBasic injeta diretamente o authProvider na opção de Auth Proxy do Axios, porém tal opção permite apenas a passagem de um objeto JS com duas propriedades { username: string; password: string; }.

// src/base.ts

class ClientBasic implements ClientBasicInterface {
  clientOptions: ClientOptions;
  client: AxiosInstance;
  auth: object;
  constructor(baseUrl: string, clientOptions: ClientOptions) {
    this.clientOptions = clientOptions;
    this.auth = {};

    if (!this.clientOptions.timeout) this.clientOptions.timeout = 5000;
    if (typeof this.clientOptions.retryDelay !== 'number')
      this.clientOptions.retryDelay = 3;
    if (typeof this.clientOptions.tries !== 'number')
      this.clientOptions.tries = 0;

    this.client = axios.create({
      baseURL: baseUrl,
      auth: this.clientOptions.authProvider // <- Injeção do Auth Provider
    });

    axiosRetry(this.client, {
      retries: this.clientOptions.tries,
      retryDelay: this.retryDelay,
      retryCondition: this.retryCondition
    });
  }
  // ...
}

Sendo assim seria necessário outra abordagem para garantir a execução correta dos Provedores de autenticação.
Segue o link da documentação do Axios sobre essa parte de autenticação: https://axios-http.com/docs/req_config

Describe the bug

In the makeRequest method, the contentType is hardcoded to 'application/x-www-form-urlencoded'. Additionally, the 'data' parameter isn't being set, even when provided as an argument.

Your minimal, reproducible example

none

Steps to reproduce

1. Define a class that inherits from ZendeskClient.
2. Implement a custom method that invokes makeRequest.
3. Ensure you pass the contentType and data parameters.

Expected behavior

As a developer, I'd like the ability to specify various 'contentTypes' and to utilize HTTP methods beyond just GET when employing the ZAF request client.

How often does this bug happen?

Every time

Screenshots or Videos

Platform

• OS: Ubuntu 20.04
• Node: 19.1.0
• Typescript: 4.9.5
• React: 18.2.0

Package version

v1.3.2

Additional context

No response

Describe the bug

• The client-core lacked a method to retrieve all data from an API, making it essential to provide this functionality to the library users.
• Additionally, the endpoint's update method had the PUT method hardcoded, but there was a requirement to also support the PATCH option.

Your minimal, reproducible example

none

Steps to reproduce

1. Define a class that inherits from ZendeskClient or AxiosClient.
2. Construct the update endpoint.
3. Invoke the update method and observe that the PATCH method cannot be called.

Expected behavior

• As a developer, I wanted the ability to fetch all data from an endpoint.
• Additionally, I hoped to utilize the PATCH method when using update endpoint.

How often does this bug happen?

Every time

Screenshots or Videos

Platform

• OS: Ubuntu 20.04
• Node: 19.1.0
• Typescript: 4.9.5
• React: 18.2.0

Package version

v1.3.3

Additional context

No response